do not minify constructor class names

QwikDev · Oct 1, 2021 · fe8d685 · fe8d685 · vercel · Oct 1, 2021
1 parent a87297a
commit fe8d685
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 0 deletions.
diff --git a/scripts/minify.ts b/scripts/minify.ts
@@ -16,6 +16,7 @@ function minifyOptions(debug: boolean): MinifyOptions {
         global_defs: {
           'globalThis.partytownDebug': true,
         },
+        keep_classnames: true,
         inline: false,
         join_vars: false,
         loops: false,
@@ -37,6 +38,7 @@ function minifyOptions(debug: boolean): MinifyOptions {
       global_defs: {
         'globalThis.partytownDebug': false,
       },
+      keep_classnames: keepConstructorNames(),
       ecma: 2018,
       passes: 2,
       unsafe_symbols: true,
@@ -45,9 +47,17 @@ function minifyOptions(debug: boolean): MinifyOptions {
       comments: false,
       ecma: 2018,
     },
+    keep_classnames: keepConstructorNames(),
+    mangle: {
+      keep_classnames: keepConstructorNames(),
+    },
   };
 }
 
+function keepConstructorNames() {
+  return /HTMLAnchorElement|HTMLIFrameElement|HTMLScriptElement|HTMLDocument|HTMLElement|Node|Window/;
+}
+
 function managlePropsPlugin(): Plugin {
   const chars = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ$'.split('');
   const mangleProps: { [key: string]: string } = {

diff --git a/tests/platform/document-prod/document-prod.spec.ts b/tests/platform/document-prod/document-prod.spec.ts
@@ -53,4 +53,7 @@ test('document-prod', async ({ page }) => {
   await expect(testCurrentScriptSrcLocation).toHaveText(
     '/platform/document-prod/current-script-src.js'
   );
+
+  const testDocCstrName = page.locator('#testDocCstrName');
+  await expect(testDocCstrName).toHaveText('HTMLDocument');
 });
diff --git a/tests/platform/document-prod/index.html b/tests/platform/document-prod/index.html
@@ -292,6 +292,17 @@ <h1 class="title">Document Prod</h1>
         </script>
       </li>
 
+      <li>
+        <strong>document.constructor.name</strong>
+        <code id="testDocCstrName"></code>
+        <script type="text/partytown">
+          (function () {
+            const elm = document.getElementById('testDocCstrName');
+            elm.textContent = document.constructor.name;
+          })();
+        </script>
+      </li>
+
       <script type="text/partytown">
         (function () {
           document.body.classList.add('completed');

diff --git a/tests/platform/document/document.spec.ts b/tests/platform/document/document.spec.ts
@@ -69,4 +69,7 @@ test('document', async ({ page }) => {
 
   const testDocType = page.locator('#testDocType');
   await expect(testDocType).toHaveText('10 html html false');
+
+  const testDocCstrName = page.locator('#testDocCstrName');
+  await expect(testDocCstrName).toHaveText('HTMLDocument');
 });
diff --git a/tests/platform/document/index.html b/tests/platform/document/index.html
@@ -319,6 +319,17 @@ <h1 class="title">Document</h1>
         </script>
       </li>
 
+      <li>
+        <strong>document.constructor.name</strong>
+        <code id="testDocCstrName"></code>
+        <script type="text/partytown">
+          (function () {
+            const elm = document.getElementById('testDocCstrName');
+            elm.textContent = document.constructor.name;
+          })();
+        </script>
+      </li>
+
       <script type="text/partytown">
         (function () {
           document.body.classList.add('completed');