apply sync setters in args

QwikDev · Oct 3, 2021 · 4965587 · 4965587 · vercel · Oct 3, 2021
1 parent 0a018c2
commit 4965587
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 5 deletions.
diff --git a/scripts/index.ts b/scripts/index.ts
@@ -30,11 +30,11 @@ export async function runBuild(rootDir: string, isDev: boolean, generateApi: boo
 
 async function createRootPackage(opts: BuildOptions) {
   if (opts.isDev) {
-    await emptyDir(opts.distDir);
-    await emptyDir(opts.distTestsDir);
-  } else {
     await ensureDir(opts.distDir);
     await ensureDir(opts.distTestsDir);
+  } else {
+    await emptyDir(opts.distDir);
+    await emptyDir(opts.distTestsDir);
   }
 
   await ensureDir(opts.distIntegrationDir);

diff --git a/src/lib/web-worker/worker-proxy.ts b/src/lib/web-worker/worker-proxy.ts
@@ -134,13 +134,20 @@ export const callMethod = (
   immediateSetters?: ImmediateSetter[],
   newInstanceId?: number
 ) => {
-  applyBeforeSyncSetters(instance[WinIdKey], instance);
+  const winId = instance[WinIdKey];
+  applyBeforeSyncSetters(winId, instance);
+
+  args.forEach((arg) => {
+    if (arg) {
+      applyBeforeSyncSetters(winId, arg);
+    }
+  });
 
   const rtn = queueTask(
     instance,
     AccessType.CallMethod,
     memberPath,
-    serializeForMain(instance[WinIdKey], instance[InstanceIdKey], args),
+    serializeForMain(winId, instance[InstanceIdKey], args),
     immediateSetters,
     newInstanceId
   );

diff --git a/tests/platform/node/index.html b/tests/platform/node/index.html
@@ -174,6 +174,19 @@ <h1 class="title">Node</h1>
         </script>
       </li>
 
+      <li>
+        <strong>compareDocumentPosition()</strong>
+        <code id="testCompareDocumentPosition"></code>
+        <script type="text/partytown">
+          (function () {
+            const elm = document.getElementById('testCompareDocumentPosition');
+            const div = document.createElement('div');
+            const p = elm.compareDocumentPosition(div);
+            elm.textContent = p;
+          })();
+        </script>
+      </li>
+
       <script type="text/partytown">
         (function () {
           document.body.classList.add('completed');

diff --git a/tests/platform/node/node.spec.ts b/tests/platform/node/node.spec.ts
@@ -31,4 +31,7 @@ test('node', async ({ page }) => {
 
   const testFragmentChildNodes = page.locator('#testFragmentChildNodes');
   await expect(testFragmentChildNodes).toHaveText('1 DIV SPAN fragment');
+
+  const testCompareDocumentPosition = page.locator('#testCompareDocumentPosition');
+  await expect(testCompareDocumentPosition).toHaveText('37');
 });