New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable to fail if clippy warnings exist #11

Merged

CKiumi merged 1 commit into main from fail-if-clippy-warning-exists

Aug 23, 2022

Collaborator

y-yu commented Aug 18, 2022 •

edited

Loading

Change Gate constructor to structure like intead of tuple like #9 and Add CCNOT and CCZ gate #10 have some clippy warnings but CI wouldn't fail
- https://github.com/QunaSys/qurs/runs/7785708664?check_suite_focus=true#step:4:217
Use -D warnings option for clippy, we make CI fail if the code has any warnings
Drop actions-rs/clippy-check because it seems to hasn't been maintained yet 😇
- Maintenance Status actions-rs/clippy-check#162

y-yu force-pushed the fail-if-clippy-warning-exists branch from 81ef90c to 96e2d47 Compare

August 18, 2022 12:17

coveralls commented Aug 18, 2022 •

edited

Loading

Pull Request Test Coverage Report for Build 2882610825

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.744%

Totals
Change from base Build 2811998560:	0.0%
Covered Lines:	369
Relevant Lines:	457

💛 - Coveralls

y-yu force-pushed the fail-if-clippy-warning-exists branch 2 times, most recently from e458d57 to 95c74b6 Compare

August 18, 2022 12:55


          Enable to fail if clippy warnings exist

266f21a

y-yu force-pushed the fail-if-clippy-warning-exists branch from 95c74b6 to 266f21a Compare

August 18, 2022 13:00

y-yu requested a review from CKiumi

August 18, 2022 13:08

CKiumi merged commit 5c4b230 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet