Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#246 benchmarkの学習回数が一致していない #247

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Conversation

forest1040
Copy link
Contributor

@forest1040 forest1040 commented Oct 6, 2022

irisのデータが100件で、trainデータに75件取っているので、学習データは50件にあわせます。
penylaneは、n_epoch = 20で、それぞれbatch_size = 5でデータを取っているので20x5で100データだったので、n_epoch = 10 にしました。
https://github.com/Qulacs-Osaka/scikit-qulacs/blob/main/benchmarks/binary_classification_pennylane.py#L149
scikit-qulacs

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #247 (9c309bf) into main (c266313) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   91.85%   91.90%   +0.04%     
==========================================
  Files          12       12              
  Lines         884      889       +5     
  Branches      171      169       -2     
==========================================
+ Hits          812      817       +5     
  Misses         41       41              
  Partials       31       31              
Impacted Files Coverage Δ
skqulacs/save.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@forest1040 forest1040 requested a review from ikanago October 6, 2022 00:28
Copy link
Contributor

@ikanago ikanago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です!

@forest1040 forest1040 merged commit fd0228c into main Oct 11, 2022
@forest1040 forest1040 deleted the fix-bench branch October 11, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants