-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MultiJson to improve JSON performance when possible #106
Conversation
@ezkl if you rebase this, I will merge and cut a new release. |
What do you think of the json parser in ruby's stdlib? Would it be simpler to use it instead? |
@ryandotsmith no it won't. MultiJson is pretty standard solution now, and the main point is that it can use different backends with no configuration (and degrades to stdlib parser or, in worst case, OkJson). If original author won't show up in foreseeable future and you don't want to rebase/add testcases, let me know, I'd be happy to do that. Cheers, and thanks for this neat exploitation of Postgres' awesomeness! |
It's been quite some time since we had activity on this ticket. @arr-ee do you think you could take this one over? |
Yeah, sure. Will try to push it this evening (i'm in UTC+8) |
@arr-ee ❤️ |
Oof. Sorry for the delay. Must have missed the previous GH notifications. |
@ezkl thanks, do you think you could add that test-case? Also there are 4 commits attached, could you squash them into a single one so that we have all the changes together? |
@@ -20,4 +20,6 @@ Gem::Specification.new do |s| | |||
s.require_paths = %w[lib] | |||
|
|||
s.add_dependency "pg", "~> 0.14.1" | |||
s.add_dependency "scrolls", "~> 0.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we no longer have a dependency on scrolls
is it necessary to introduce it again?
@ezkl would be great if you could add the test-case. Also can you squash your commits together and push a rebased version? |
Thanks for the update! If I'm not mistaken the current tests already exercise your code path. If that's the case I think we don't need an extra test-case. |
👍 |
Use MultiJson to improve JSON performance when possible
@ezkl thanks! |
Readme still mentions OkJson. |
@nashbridges thanks for the hint. I updated the README: f251345 |
This pull-request is a response to #99. It simply replaces OkJson w/ Intridea's MultiJson.
From the README:
As an example, to leverage the awesome Oj, add
gem 'oj', '>= 1.3.5'
to your app's Gemfile andbundle install
. MultiJson will automatically use Oj for QC's JSON processing.@ryandotsmith I didn't touch the tests. Would you like me to add one to assert that MultiJson is working properly?