Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qpm qmod build for generating qmod zips #40

Merged
merged 14 commits into from
Apr 15, 2024
Merged

Conversation

Fernthedev
Copy link
Collaborator

@Fernthedev Fernthedev commented Apr 9, 2024

Changes:

  • Replaces qpm qmod build (alias for qpm qmod manifest) with a new command
  • Removes --isLibrary flag

Making a qmod zip

Example:
qpm qmod build ./my_qmod.qmod --includeDirs ./build,./assets

  • QPM will start by generating a mod.json from a mod.template.json exactly as qpm qmod manifest does, but without writing to the file system.
  • Next, QPM will iterate the following keys and try to find them in the provided --includeDirs flag. If a file with the name isn't found, an error will be thrown. This will be done in the order given in the argument.
    • libraryFiles
    • modFiles
    • lateModFiles
    • fileCopies
  • Finally QPM opens the zip file, adds all the files and finally adds the mod.json

Things to consider:

  • Should this run qpm s build automatically, or let the caller decide by doing so manually
  • Should an argument for providing a prebuilt mod.json be supported, in the case where using mod.template.json is undesirable.
  • Others

@Fernthedev
Copy link
Collaborator Author

Renamed to zip

Add ability to set default includes in qpm.json::workspace::qmod_includesand qpm.json::workspace::qmod_output

@Fernthedev
Copy link
Collaborator Author

Example command
qpm qmod zip --include_dirs ./build -i ./extern/libs

@Fernthedev Fernthedev merged commit c21434f into main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant