Update to qt6 #387
Update to qt6 #387
Conversation
marmarta
force-pushed
the
update_to_qt6
branch
11 times, most recently
from
f297823 to
9867550
Compare
marmarta
force-pushed
the
update_to_qt6
branch
3 times, most recently
from
6020848 to
357c529
Compare
|
@marmarek , could I get this tested in openqa? There are multiple ways this could go wrong, I'd like to see how it looks on a non-frankenstein system. |
|
Sure |
marmarta
force-pushed
the
update_to_qt6
branch
from
357c529 to
e447809
Compare
|
openqa worked, in that it found an instant death bug. Asking for another round. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024110404-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 200 fixed
Unstable tests
|
|
There should be also info what about cloned templates or otherwise not installed with qvm-template initially. Currently they are completely missing on the list, and there is no info there might be some other templates somewhere. |
|
There is updated openQA run, with another set of failures (see updated comment), but also: |
Changed Template Manager UI to be more friendly. Added a lot of explanations. Functionally, added checking for obsolete templates.
Updated all files to Qt version 6. Based on the template manager redesign. fixes QubesOS/qubes-issues#9476
And also to improve code readability.
Removed CI build for Ubuntu Jammy, because it does not contain necessary pyqt6 packages; newer versions do contain it.
marmarta
force-pushed
the
update_to_qt6
branch
from
56c76a6 to
abd77fc
Compare
|
another round of changes done; I removed the Abort button for now. |
marmarta
force-pushed
the
update_to_qt6
branch
from
abd77fc to
878e165
Compare
|
hopefully I fixed the damn async bugs here. I'm going to be chased by coroutines in my nightmares today. |
marmarta
force-pushed
the
update_to_qt6
branch
from
878e165 to
4ebab92
Compare
| @@ -225,11 +225,14 @@ | |||
| <item> | |||
| <widget class="QTextEdit" name="confirm_text_edit"> | |||
| <property name="html"> | |||
| <string> | |||
| <html><head><meta name="qrichtext" content="1" /><style type="text/css"> | |||
| <string><!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"> | |||
There was a problem hiding this comment.
| <string><!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"> | |
| <string><!DOCTYPE html> |
The other HTML DOCTYPEs are deprecated.
There was a problem hiding this comment.
this is generated by designer-qt, so you can report this upstream. Editing it manually is a bad idea. Same to your comments on QubesOS/qubes-desktop-linux-menu#50
There was a problem hiding this comment.
I did not realize this was generated code.
There was a problem hiding this comment.
while in this file it might not be obvious, the ones in the other PR literally have "generated by XYZ software" in them...
- fix import order (tests fail when helper files import qasync before pyqt6) - clean up some run_until completes - minor test fixes
marmarta
force-pushed
the
update_to_qt6
branch
from
4ebab92 to
c29be64
Compare
|
hopefully fixed the last failing test... |
Update all programs to use Qt6. May or may not cause weird palette bugs in dom0 (local testing inconclusive); please test.
Based on #382
Does not involve any actual changes in functionality (hopefully).
fixes QubesOS/qubes-issues#9476