spec: add BR make and update R pyqt5 #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
requested changes
Oct 26, 2021
rpm_spec/qmgr.spec.in
Outdated
| @@ -8,7 +8,11 @@ Vendor: Invisible Things Lab | |||
| License: GPL | |||
| URL: https://www.qubes-os.org | |||
| Requires: python%{python3_pkgversion} | |||
| %if 0%{?fedora} >= 34 | |||
| Requires: python%{python3_pkgversion}-pyqt5-sip | |||
There was a problem hiding this comment.
It looks rather like some devel tool, not the actual pyqt. On the other hand, I see python3-qt5 package that provides python3-PyQt5 name too (at least according to https://src.fedoraproject.org/rpms/python-qt5/blob/f35/f/python-qt5.spec). What's exactly the reason for this change?
There was a problem hiding this comment.
That was the only match for python3-pyqt5 while attempting to build it. You are right that's certainly the right choice because I was not sure for this one.
Thanks to @marmarek's suggestion. QubesOS/qubes-issues#6982
marmarek
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QubesOS/qubes-issues#6982