Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split-gpg2 should not pass OPTION display to the agent #9527

Open
DemiMarie opened this issue Oct 22, 2024 · 0 comments · May be fixed by QubesOS/qubes-app-linux-split-gpg2#17
Open

split-gpg2 should not pass OPTION display to the agent #9527

DemiMarie opened this issue Oct 22, 2024 · 0 comments · May be fixed by QubesOS/qubes-app-linux-split-gpg2#17
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: split-gpg2 split-gpg version 2 diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@DemiMarie
Copy link

DemiMarie commented Oct 22, 2024 •
edited
Loading

How to file a helpful issue

Qubes OS release

R4.2

Brief summary

split-gpg2 should not pass OPTION display to the agent. It makes no sense in a VM and should just get a fake OK response.

Steps to reproduce

Use Sequoia Chameleon.

Expected behavior

Works

Actual behavior

Fails because the connection to the agent is restricted. If the connection were unrestricted it would still not make sense. If the option must be set at all, split-gpg2 should set it unconditionally.
@DemiMarie DemiMarie added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. diagnosed Technical diagnosis has been performed (see issue comments). C: split-gpg2 split-gpg version 2 affects-4.2 This issue affects Qubes OS 4.2. labels Oct 22, 2024
This was referenced Oct 22, 2024
Open
Open
DemiMarie added a commit to DemiMarie/qubes-app-linux-split-gpg2 that referenced this issue Oct 22, 2024
@DemiMarie
Return fake 'OK' to setting 'display' option
58efb86 
This option makes no sense in the context of split-gpg2 and fails if the
gpg-agent-connection is restricted, causing Sequoia Chameleon to
disconnect.  Return a fake 'OK' response instead of passing the command
to the agent.

Fixes: QubesOS/qubes-issues#9527
@DemiMarie DemiMarie linked a pull request Oct 22, 2024 that will close this issue
Open
@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: split-gpg2 split-gpg version 2 diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix use with Sequoia Chameleon DemiMarie/qubes-app-linux-split-gpg2
2 participants
@DemiMarie @andrewdavidwong