Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qrexec hangs if the service config is invalid #9073

Closed
DemiMarie opened this issue Mar 31, 2024 · 0 comments · Fixed by QubesOS/qubes-core-qrexec#138
Closed

qrexec hangs if the service config is invalid #9073

DemiMarie opened this issue Mar 31, 2024 · 0 comments · Fixed by QubesOS/qubes-core-qrexec#138
Assignees
@DemiMarie
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.

Comments

@DemiMarie
Copy link

How to file a helpful issue

Qubes OS release

R4.2 but R4.1 is probably also affected.

Brief summary

If the service configuration is invalid, the data vchan connection is never established and the call eventually times out.

Steps to reproduce

Create a qrexec service with an invalid config file, then try to invoke the service.

Expected behavior

Call fails quickly.

Actual behavior

Call times out.
@DemiMarie DemiMarie added T: bug C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. affects-4.2 This issue affects Qubes OS 4.2. labels Mar 31, 2024
@DemiMarie DemiMarie self-assigned this Mar 31, 2024
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue Mar 31, 2024
@DemiMarie
Cleanly terminate connections if command or config is invalid
5e37628 
Send exit status 127 in this case, as if the command could not be found.
This prevents the caller from hanging, and allows this situation to be
tested.

Fixes: QubesOS/qubes-issues#9073
@andrewdavidwong andrewdavidwong added affects-4.1 This issue affects Qubes OS 4.1. diagnosed Technical diagnosis has been performed (see issue comments). labels Mar 31, 2024
DemiMarie added a commit to DemiMarie/qubes-core-qrexec that referenced this issue Apr 1, 2024
@DemiMarie
Cleanly terminate connections if command or config is invalid
478b64b 
Send exit status 127 in this case, as if the command could not be found.
This prevents the caller from hanging, and allows this situation to be
tested.

Fixes: QubesOS/qubes-issues#9073
@DemiMarie DemiMarie mentioned this issue Apr 1, 2024
Merged
@DemiMarie DemiMarie mentioned this issue Apr 2, 2024
Open
@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Apr 3, 2024
This was referenced May 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DemiMarie DemiMarie

Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support not passing metadata to socket-based services DemiMarie/qubes-core-qrexec
2 participants
@DemiMarie @andrewdavidwong