Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"default-kernel" global property doesn't validate if the kernel exists #8992

Closed
marmarek opened this issue Feb 28, 2024 · 3 comments · Fixed by QubesOS/qubes-core-admin#613
Closed

"default-kernel" global property doesn't validate if the kernel exists #8992

marmarek opened this issue Feb 28, 2024 · 3 comments · Fixed by QubesOS/qubes-core-admin#613
Assignees
@alimirjamali
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). good first issue This is a recommended issue for first-time contributors. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@marmarek
Copy link
Member

How to file a helpful issue

Qubes OS release

R4.2 (likely R4.1 too)

Brief summary

Setting default-kernel to invalid value prevents starting any qube. qubesd should refuse to set invalid value.

Steps to reproduce

qubes-prefs default-kernel xxx

Expected behavior

xxx value is refused

Actual behavior

Value is accepted and no qube can start due to non-existing kernel.
@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. diagnosed Technical diagnosis has been performed (see issue comments). affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. good first issue This is a recommended issue for first-time contributors. labels Feb 28, 2024
@alimirjamali
Copy link

alimirjamali commented Aug 16, 2024 •
edited
Loading

It appears that the readily available property-pre-set:kernel event and on_property_pre_set_kernel of QubesVM could not be reused here.

Doing it at qubes-core-admin-client level will not be a proper fix?

@marmarek
Copy link
Member Author

Doing it at qubes-core-admin-client level will not be a proper fix?

No, it should be done on the backend side.

It appears that the readily available property-pre-set:kernel event and on_property_pre_set_kernel of QubesVM could not be reused here.

I think it can be extracted to a helper function, and then connected to a property-pre-set:default_kernel event on the app object.

alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 16, 2024
@alimirjamali
Validate default_kernel global property
fe76c68 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 16, 2024
@alimirjamali
Validate default_kernel global property on set
cab29e9 
fixes: QubesOS/qubes-issues#8992
@alimirjamali alimirjamali mentioned this issue Aug 16, 2024
Merged
@alimirjamali
Copy link

I think it can be extracted to a helper function, and then connected to a property-pre-set:default_kernel event on the app object.

Ok. It is done at Daemon level.

PS Submitted

Review priority: low

@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Aug 17, 2024
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
6e4df05 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
f03a57e 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
b044b86 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
029ae55 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
f66b0dc 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
cb4def9 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
22e07a7 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
31daa6c 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
4bec5ec 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
434537a 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
386961c 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
134e971 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 18, 2024
@alimirjamali
Validate default_kernel global property on set
62ff1f1 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 19, 2024
@alimirjamali
Validate default_kernel global property on set
8b03df9 
fixes: QubesOS/qubes-issues#8992
alimirjamali added a commit to alimirjamali/qubes-core-admin that referenced this issue Aug 19, 2024
@alimirjamali
Validate default_kernel global property on set
9991c35 
fixes: QubesOS/qubes-issues#8992
@qubesos-bot qubesos-bot mentioned this issue Oct 4, 2024
Closed
marmarek pushed a commit to QubesOS/qubes-core-admin that referenced this issue Dec 8, 2024
@alimirjamali @marmarek
Validate default_kernel global property on set
052a1b7 
fixes: QubesOS/qubes-issues#8992
(cherry picked from commit 151010d)
@qubesos-bot qubesos-bot mentioned this issue Dec 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimirjamali alimirjamali

Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). good first issue This is a recommended issue for first-time contributors. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate default_kernel global property on set alimirjamali/qubes-core-admin
3 participants
@marmarek @alimirjamali @andrewdavidwong