Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducible Qube Manager crash on launching a qube's Settings #8757

Closed
UndeadDevel opened this issue Dec 8, 2023 · 15 comments
Closed

Reproducible Qube Manager crash on launching a qube's Settings #8757

UndeadDevel opened this issue Dec 8, 2023 · 15 comments
Assignees
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.2-host-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@UndeadDevel
Copy link

Qubes OS release

4.2rc5

Brief summary

Reproducable on my machine 100% of times so far. It seems to only resolve itself (settings available again) when the 5 minutes are up (firewall full access rule).

Steps to reproduce

  1. create new AppVM (in my case based on debian-12-xfce) with default networking (sys-firewall as netVM)
  2. open this qube's Settings via the domains widget and set firewall rules to "limit outgoing connections" and put checkmark on "allow full access for", press ok
  3. Run (from dom0; I assume that the qube's name has been stored in qube):
qvm-prefs $qube netvm None
qvm-prefs $qube netvm -D
  1. Try to open this qube's Settings again via the domains widget and observe error message (see "Actual behavior")

Expected behavior

no errors or crashes

Actual behavior

error_message_qube-manager_when_trying_to_open_settings
Text in that error window:

----
line: self.temp_full_access_time.setValue(
func: set_fw_model
line no.: 1464
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: self.set_fw_model(model)
func: __init__
line no.: 192
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: window = window_class(qt_app, qubes_app)
func: run_synchronous
line no.: 558
file: /usr/lib/python3.11/site-packages/qubesmanager/utils.py
----
line: utils.run_synchronous(functools.partial(VMSettingsWindow, vm, args.tab))
func: main
line no.: 1540
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: sys.exit(load_entry_point('qubesmanager==4.2.7', 'console_scripts', 'qubes-vm-settings')())
func: <module>
line no.: 33
file: /usr/bin/qubes-vm-settings

dom0 sudo journalctl output when subsequently trying to open the Qubes Manager via the domains widget list item (very large):
journalctl_output_when_subsequently_trying_to_open_the_qube_manager_via_qube_widget_link.log

@UndeadDevel UndeadDevel added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Dec 8, 2023
@UndeadDevel UndeadDevel changed the title Reproducable Qubes Manager crash on launching qube settings Reproducible Qube Manager crash on launching a qube's Settings Dec 8, 2023
@andrewdavidwong andrewdavidwong added needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. affects-4.2 This issue affects Qubes OS 4.2. labels Dec 10, 2023
marmarta added a commit to marmarta/qubes-manager that referenced this issue Dec 11, 2023
@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bullseye-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package manager) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package manager) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package manager) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Jan 5, 2024
@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package manager) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package manager) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component manager (including package manager) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@UndeadDevel
Copy link
Author

UndeadDevel commented Feb 11, 2024

This is still not fixed, can still reproduce in an up-to-date Debian-12 based AppVM. Also, this issue seems to be a duplicate of #8685.

Edit: oh and I see that the manager update is actually still in testing...disregard above then, except for this being a duplicate.

@andrewdavidwong
Copy link
Member

This is still not fixed, can still reproduce in an up-to-date Debian-12 based AppVM. Also, this issue seems to be a duplicate of #8685.

Edit: oh and I see that the manager update is actually still in testing...disregard above then, except for this being a duplicate.

Ordinarily, you're correct that we would close #8757 (the newer issue) as a duplicate of #8685 (the older issue). However, since #8757 is already closed as fixed, and the commits are associated with #8757, we can close #8685 as a duplicate instead.

@UndeadDevel
Copy link
Author

UndeadDevel commented May 19, 2024

This seems to have been fixed only for float operand types, not int and str...so the issue is still reproducible under the same conditions, but now with a different error message (TypeError: unsupported operand type(s) for-: 'int' and 'str' at line 33 of file /usr/bin/qubes-vm-settings):
See this comment for the error window, and comment below for new error log, but it seems it was decided to deal with this new error message in the other issue (#8685).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.2-host-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

5 participants