Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers tags/attributes #865

Closed
marmarek opened this issue Mar 8, 2015 · 3 comments
Closed

Containers tags/attributes #865

marmarek opened this issue Mar 8, 2015 · 3 comments
Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. release notes This issue should be mentioned in the release notes. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Milestone

Comments

@marmarek
Copy link
Member

marmarek commented Mar 8, 2015

Reported by joanna on 2 Jun 2014 12:45 UTC
See:

https://groups.google.com/forum/#!topic/qubes-devel/qzM5QRE8Ua8

I don't like the idea with using the VM type as a policy parameter,
because it is not meant to reflect the "security/trust level" of the
VM in question. We have a special property in Qubes that is specifically
allocated for this purpose and this is the VM color label.

So, I like the idea of using the vm names and labels (as Marek wrote
above) in the policy definitions, but not vm types.

The regexp-based rules (but only expanding to vm names, not labels!)
might be a good idea, although I'm worrying a bit that they might easily
lead to situations when the user shoots themselves in the foot, simply
because the regexp is to be expanded differently than the user expect, a
popular problem with advanced regexp usage (Happens to me all the time
when I use grep or sed ;) So this really would need to be "simple" regexp...

I'm thinking whether vm name and label will be "enough for everybody" or
should we consider introduction of also additional properties to VMs?
Perhaps user definable properties? E.g.:

qvm-prefs work -s corporate
qvm-prefs accounting -s corporate

And then in the policy (e.g. qubes.ClipboardPaste):

$property:corporate $property:corporate allow
$property:corporate $anyvm deny

joanna.

Migrated-From: https://wiki.qubes-os.org/ticket/865

@marmarek marmarek added this to the Release 3 milestone Mar 8, 2015
@marmarek marmarek added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. C: core P: major Priority: major. Between "default" and "critical" in severity. labels Mar 8, 2015
@marmarek marmarek modified the milestones: Release 4.0, Release 3.0 May 13, 2015
@andrewdavidwong andrewdavidwong added the help wanted This issue will probably not get done in a timely fashion without help from community contributors. label Jun 9, 2016
andrewdavidwong added a commit that referenced this issue Jun 9, 2016
@woju woju mentioned this issue Oct 21, 2016
4 tasks
@Rudd-O
Copy link

Rudd-O commented Oct 28, 2016

It's certainly time to evolve past colors and into labels. Of course, each label can have a color / stipple pattern associated with it (by default we just pick one that hasn't been used before), but the color itself is a bad mnemonic for what the security properties of the VM ought to be.

@marmarek
Copy link
Member Author

Actually, in the current shape of Qubes 4.0 it is already possible to assign tags to VMs. The missing part is have them used somewhere (for example qrexec policy as described above).

woju added a commit to woju/qubes-core-admin that referenced this issue Dec 1, 2016
woju added a commit to woju/qubes-core-admin that referenced this issue Dec 2, 2016
woju added a commit to woju/qubes-core-admin that referenced this issue Dec 2, 2016
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Mar 20, 2017
This is rewritten version of core-admin-linux/qrexec/qrexec-policy.

It's placed outside of `qubes` module on purpose - to avoid imporing it,
which require a lot of time.

QubesOS/qubes-issues#865
QubesOS/qubes-issues#910
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Mar 21, 2017
This is rewritten version of core-admin-linux/qrexec/qrexec-policy.

It's placed outside of `qubes` module on purpose - to avoid imporing it,
which require a lot of time.

QubesOS/qubes-issues#865
QubesOS/qubes-issues#910
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Mar 21, 2017
This is rewritten version of core-admin-linux/qrexec/qrexec-policy.

It's placed outside of `qubes` module on purpose - to avoid imporing it,
which require a lot of time.

QubesOS/qubes-issues#865
QubesOS/qubes-issues#910
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Mar 31, 2017
This is rewritten version of core-admin-linux/qrexec/qrexec-policy.

It's placed outside of `qubes` module on purpose - to avoid imporing it,
which require a lot of time.

QubesOS/qubes-issues#865
QubesOS/qubes-issues#910
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Apr 6, 2017
This is rewritten version of core-admin-linux/qrexec/qrexec-policy.

It's placed outside of `qubes` module on purpose - to avoid imporing it,
which require a lot of time.

QubesOS/qubes-issues#865
QubesOS/qubes-issues#910
@marmarek
Copy link
Member Author

Done

@marmarek marmarek added release notes This issue should be mentioned in the release notes. and removed help wanted This issue will probably not get done in a timely fashion without help from community contributors. labels Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. release notes This issue should be mentioned in the release notes. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Development

No branches or pull requests

3 participants