Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fido2 implementation breaks on Debian-based sys-usb #8529

Closed
ctr49 opened this issue Sep 19, 2023 · 5 comments
Closed

fido2 implementation breaks on Debian-based sys-usb #8529

ctr49 opened this issue Sep 19, 2023 · 5 comments
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: CTAP/U2F proxy Client to Authenticator Protocol (CTAP) / Universal 2nd Factor (U2F) proxy C: Debian/Ubuntu diagnosed Technical diagnosis has been performed (see issue comments). eol-4.1 Closed because Qubes 4.1 has reached end-of-life (EOL) P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@ctr49
Copy link

ctr49 commented Sep 19, 2023

It seems #31 requires python3-fido2 >= 1.0.0 (only then AttestationResponse was introduced for tap).

However, Debian ships with lower versions (Bullseye with 0.8.1, Bookworm with 0.9.1) so this will not work on a Debian-based sys-usb.

Originally posted by @ctr49 in QubesOS/qubes-app-u2f#31 (comment)
@marmarek marmarek transferred this issue from QubesOS/qubes-app-u2f Sep 19, 2023
@andrewdavidwong andrewdavidwong added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: Debian/Ubuntu P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. C: usb proxy labels Sep 19, 2023
@andrewdavidwong
Copy link
Member

Does this affect 4.1 or 4.2 (or both)?

@andrewdavidwong andrewdavidwong added needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. diagnosed Technical diagnosis has been performed (see issue comments). C: CTAP/U2F proxy Client to Authenticator Protocol (CTAP) / Universal 2nd Factor (U2F) proxy and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. C: usb proxy labels Sep 19, 2023
marmarek added a commit to QubesOS/qubes-app-u2f that referenced this issue Sep 19, 2023
@marmarek
Exclude package on Debian 10 and 11
e235b55 
Debian 11 (bullseye) and older do not have python3-poetry required for
building new enough python3-fido2. Since that's Debian oldstable
already, exclude the package there.

QubesOS/qubes-issues#8529
This was referenced Sep 19, 2023
Closed
Closed
@andrewdavidwong
Copy link
Member

Ah, looks like both.

@andrewdavidwong andrewdavidwong added affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. labels Sep 19, 2023
marmarek added a commit to QubesOS/qubes-builderv2 that referenced this issue Sep 19, 2023
@marmarek
R4.2: add python-fido2 to the config
a6416da 
QubesOS/qubes-issues#8529
marmarek added a commit to QubesOS/qubes-builder that referenced this issue Sep 19, 2023
@marmarek
example-configs: add python-fido2 to both R4.1 and R4.2
87e737c 
Debian ships with too old version for app-u2f, ship an update via Qubes
respositories until newer version is available in Debian repositories

https://bugs.debian.org/1042109
QubesOS/qubes-issues#8529
marmarek added a commit to QubesOS/qubes-app-u2f that referenced this issue Sep 20, 2023
@marmarek
debian: require new enough python3-fido2
4d45d9a 
QubesOS/qubes-issues#8529
Closed
This was referenced Sep 20, 2023
Closed
Closed
@marmarek
Copy link
Member

On Debian 12 (stable, bookworm), we've added newer python-fido2 to our repository. On older Debian it isn't that easy, so it's going to stay on older qubes-u2f package.
On R4.1, qubes-ctap never went out of testing repository, so users with Debian 11 and just stable repositories are unaffected.

But those with Debian 11 having either testing repositories enabled, or having R4.2 already (where qubes-ctap landed in stable repo) will need to downgrade qubes-u2f package on debian-11 manually. I haven't tested it, but something like this should work:

apt-get update
apt-get remove qubes-ctap
apt-get --allow-downgrades install "qubes-u2f=1.*"

@qubesos-bot qubesos-bot mentioned this issue Jan 9, 2024
Closed
@zpc0
Copy link

zpc0 commented Feb 18, 2024

Since R4.2 only support Debian 12 and this issue is fixed in Debian 12, I think "affect-4.2" can be removed.

@andrewdavidwong andrewdavidwong removed the affects-4.2 This issue affects Qubes OS 4.2. label Feb 18, 2024
@andrewdavidwong andrewdavidwong added the eol-4.1 Closed because Qubes 4.1 has reached end-of-life (EOL) label Dec 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024

This issue is being closed because:

If anyone believes that this issue should be reopened, please leave a comment saying so.
(For example, if a bug still affects Qubes OS 4.2, then the comment "Affects 4.2" will suffice.)

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: CTAP/U2F proxy Client to Authenticator Protocol (CTAP) / Universal 2nd Factor (U2F) proxy C: Debian/Ubuntu diagnosed Technical diagnosis has been performed (see issue comments). eol-4.1 Closed because Qubes 4.1 has reached end-of-life (EOL) P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@marmarek @ctr49 @andrewdavidwong @zpc0