Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rpm-template purge" asks 3 times for the same confirmation #7094

Closed
ydirson opened this issue Nov 28, 2021 · 8 comments
Closed

"rpm-template purge" asks 3 times for the same confirmation #7094

ydirson opened this issue Nov 28, 2021 · 8 comments
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.1-bookworm-stable r4.1-bullseye-stable r4.1-buster-stable r4.1-centos-stream8-stable r4.1-dom0-stable r4.1-fc34-stable r4.1-fc35-stable r4.1-fc36-stable ux User experience

Comments

@ydirson
Copy link

ydirson commented Nov 28, 2021

Qubes OS release

4.1rc2

Brief summary

[x@dom0 ~]$ qvm-template purge fedora-32
This will completely remove the selected VM(s)...
  fedora-32
Are you sure? [y/N] y
This will completely remove the selected VM(s)...
  fedora-32
Are you sure? [y/N] y
This will completely remove the selected VM(s)...
  fedora-32
Are you sure? [y/N] y
[x@dom0 ~]$ 
@ydirson ydirson added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug labels Nov 28, 2021
@noskb
Copy link

noskb commented Nov 28, 2021

Yes, if you specify purge, it will check three times

if not args.yes:
        repeat = 3 if purge else 1
        # XXX: Mutating the list later seems to break the tests...
        remove_list_copy = remove_list.copy()
        for _ in range(repeat):
            confirm_action(
                'This will completely remove the selected VM(s)...',
                remove_list_copy)

https://github.com/QubesOS/qubes-core-admin-client/blob/master/qubesadmin/tools/qvm_template.py#L1365-#L1372

@ydirson
Copy link
Author

ydirson commented Nov 28, 2021

If this is a safety measure, then the extra messages should make this clear, like "really ? this will destroy %d VMs !".
As is, it just looks like a bug, and I nearly Ctrl-C'd the 3rd time I got a strictly identical prompt.

@andrewdavidwong andrewdavidwong added C: core ux User experience labels Nov 28, 2021
@andrewdavidwong andrewdavidwong added this to the Release 4.1 updates milestone Nov 28, 2021
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Apr 12, 2022
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Apr 12, 2022
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Apr 12, 2022
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-admin-client has been pushed to the r4.1 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin-client (including package python3-qubesadmin-4.1.22-1.fc32) has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-admin-client_4.1.22-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-admin-client has been pushed to the r4.1 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-admin-client_4.1.22-1+deb10u1 has been pushed to the r4.1 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-admin-client (including package python3-qubesadmin-4.1.22-1.fc32) has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.1-bookworm-stable r4.1-bullseye-stable r4.1-buster-stable r4.1-centos-stream8-stable r4.1-dom0-stable r4.1-fc34-stable r4.1-fc35-stable r4.1-fc36-stable ux User experience
Projects
None yet
Development

No branches or pull requests

4 participants