Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'file' storage driver in R4.1, remove in R5.0 #6399

Open
marmarek opened this issue Feb 12, 2021 · 4 comments
Open

Deprecate 'file' storage driver in R4.1, remove in R5.0 #6399

marmarek opened this issue Feb 12, 2021 · 4 comments
Labels
C: core C: storage P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. release notes This issue should be mentioned in the release notes.

Comments

@marmarek
Copy link
Member

Qubes OS version (if applicable)

R4.1

Affected component(s) or functionality (if applicable)

core

Brief summary

  1. Add some verbose notification about using deprecated storage driver in R4.1. I think this can be a notification at the system startup (can be added to the code of one of the widgets, for example qui-updates one). Also, add a warning when creating new "file" pool. Maybe also when listing storage pools?
  2. Do not create "file" pool automatically during system installation. But do create file-reflink for /var/lib/qubes directory, for compatible filesystems.
  3. Document migration off the file driver (either to file-reflink or to lvm), and link to it from release notes and the notification. In-place migration is preferred if possible, otherwise document reinstall method.

Additional context

The file storage driver is very inefficient and also some features are impossible to achieve using its old architecture (it simulates CoW volumes using dm-snapshot, which limits snapshots levels to 1). Example issues caused by its inferior features:

@marmarek marmarek added T: task P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Feb 12, 2021
@marmarek marmarek added this to the Release 4.1 milestone Feb 12, 2021
@marmarek marmarek added the release notes This issue should be mentioned in the release notes. label Feb 12, 2021
@rustybird
Copy link

  1. Document migration off the file driver (either to file-reflink or to lvm), and link to it from release notes and the notification. In-place migration is preferred if possible, otherwise document reinstall method.

As a first stab at this, here's howto-qubes-btrfs-convert.md ("EXPERIMENTAL: Convert a Qubes R4.0 installation from file on ext4 to file-reflink on btrfs")

@Rudd-O
Copy link

Rudd-O commented Mar 4, 2022

Is there going to be an option for those of us using ZFS instead of LVM?

@DemiMarie
Copy link

@Rudd-O I suggest implementing a ZFS storage driver instead, or finishing the existing one. I would be willing to review a PR.

@rustybird
Copy link

Worth mentioning that the development of reflink support for ZFS seems to be making good progress. Maybe it'll land before R4.2.

rustybird added a commit to rustybird/qubes-core-admin-client that referenced this issue Apr 15, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.1 updates milestone Aug 13, 2023
@marmarek marmarek changed the title Deprecate 'file' storage driver in R4.1, remove in R4.2 Deprecate 'file' storage driver in R4.1, remove in R5.0 Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: core C: storage P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. release notes This issue should be mentioned in the release notes.
Projects
None yet
Development

No branches or pull requests

5 participants