-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using abbreviations for Whonix templates #1778
Comments
I don't think it is great idea. Those VMs are not actually Best Regards, |
I agree the proposed names are bad, they should highlight that they are templates (maybe |
Perhaps all TemplateVMs should be prefixed with 'template-'? Looping in @bnvk. How does this ticket integrate with what you had in |
I like @adrelanos's suggestion of prefixing all TemplateVMs. (Personally, I would prefer something like Prefixing is much better than postfixing in this case, because it will result in all the templates sorting together lexically. |
No, no abbreviations. We should have tab-complete to make typing such things in terminal faster. Or have no abbreviations and have clearer separation of different types of VMs (template, system, app) clearer in the VM Manager.
You can't argue I continue to run into issues with these abbreviations at trainings, whether they are native english speakers or not. The worst part is that |
What's the status of this ticket?
At this point, considered rejected as in "won't fix" or "won't do"? Or waiting for more discussion / thinking / input? Or is it dependent on the outcome of #1776? (I personally don't have any strong opinion here either way and would to refer to advice by usability designers.) |
@ninavizz I imagine this is your call |
Yes @adrelanos I would qualify this as dependent on #1776. HOWEVER, I also see #1776 as nearing completion. For the latest Whonix release, I'd prefer we not change anything, in the interest of not creating UX churn. For — EDIT — This oyster being Marek's, it's ultimately his call... tho I appreciate the callout, Demi! The above is my recommendation. :) |
Isn't this just a specific instance of #1776? What's the point of having both open? |
I don't see this issue at all dependent to #1776. the equivalent of this issue is if we named the debian or fedora minimal templates to be all this issue is asking, is -- just as we spell out this can be done independently of #1776 and we could even not implement #1776 and still fix this issue. |
@mfc Ok, so—two things. One, your point about localization and multi-lingual users is totally legit. "disp-89068" as an example, makes no sense to users that don't speak English, or do speak English but don't quickly intuit that "disp" is an abbreviation of "disposable." With For users using the new app menu, App qubes and Templates will further never be shown in the same view, which will help keep users from going to open a Template when they want to open an App qube. Given the icons will help disambiguate App qubes from Templates, would you feel satisfied with |
@andrewdavidwong I think this issue has pivoted to discussing Template name suffixes, not prefixes; but the abbreviations issue cited in the title, began as a discussion around prefixes. Both stink, tbh; but also need a longer-term solution (like a parenthetical or something). I dunno. It still feels like this is not yet solved for. |
correct this issue is not about the prefixes and is not something that icons or ordering can help solve -- all of that is in #1776. if we follow the naming convention of the minimal templates which is
which would appear when installed to the user as:
or if we consider the workstation and gateway to be separate distributions (our current practice, i'm not sure why), then we can switch the release number and workstation/gateway as we currently do. but i think the above is cleaner & clearer. |
Thanks for the explanation. I understand now. |
Ok, indeed with clearer distinction what is a template and what is not (new menu, new icons, new layout in the manager etc), I think we can go ahead with this rename.
But in this case, none of the above is a concern. Should be good. @adrelanos do you want to go with this with Whonix 16 already, or is it too late for such change, and should we schedule it for Whonix 17? |
I would prefer the long notation And I'd suggest to avoid the short notation ...but I am missing QVMM R4.1 innovations. Maybe hard to get it wrong there.
Might cause confusion if some have Whonix 16 in the legacy notation and some not if we change that now. Not sure. Doing this for Whonix 17 seems safe. Pull requests would be useful with a note to merge these for Whonix 17 so this doesn't have to be invented under pressure when Whonix 17 release time comes close or gets forgotten by then. |
That's the naming pattern for template packages, not qubes. Now you're talking about changing the naming pattern for all template qubes, not just Whonix templates. Also, the first name is longer than 31 characters.
But no one has Whonix 16 stable yet, because it doesn't exist yet. Changes to Whonix 16 unstable are fine, as it's unstable. (Note: I'm not saying you should or shouldn't do it. I'm only addressing this specific point.)
|
@mfc My comments about icons, are relevant to whether or not the word "template" is included in the name of the qube. TY @andrewdavidwong for clarifying that Michael was in fact describing packages and not qube names. Question for everyone: Why is it normal/customary in Qubes to leave old versions of things on a machine, when we have new versions? Like, is there a reason to have multiple versions of Whonix on a machine, other than "It doesn't un-install old versions"? I'd like to develop some method for tracking distro versions other than forcing them to be included in the name. At some point, not as a part of this ticket. Yes, I'm going to be chatting with @marmarta about including build/version numbers for templates in their submenus from the App Menu, and for Qubes Manager a unique UIs (variation on the existing) will also need to be developed). On the CLI some UX things will likely need to be added. |
Some users like to have multiple templates corresponding to multiple releases of an OS installed at the same time (sometimes even EOL releases). Users have a wide variety of reasons for this practice. It would be very bad if we automatically deleted any of their templates without asking simply because we assumed they were "old," and it would probably fail a lot of the time anyway, since there would probably be app qubes dependent on those templates. However, it might make sense to prompt users to ask them whether they'd like us to delete an old template that we automatically detect is no longer in use (or inform them that the old one is still in use, possibly unintentionally), e.g., as a final cleanup step after installing a new template version. |
Succinctly: a user can customize a qubes-installed template. Deleting a template loses those customizations. Customization ranges from the common use case of installing additional software to...changing system configuration to...a universe of things. A replacement template ("newly built version" not just updates to existing one) won't have those customizations and automatically deleting an old template loses those customizations. B |
Yeah. Basically, templates are (or, more precisely, can be) user data, and you never mess with user data. |
I've opened remaining PRs related to template renaming. They are not tested yet, I'll build test installer and try it out. |
Appmenu should work regardless, something went wrong. Maybe it's about "bullseye" in directory names at https://github.com/whonix/qubes-template-whonix ? |
Also https://github.com/Whonix/qubes-template-whonix/blob/master/builder.conf needs to be updated? I can do that now just in case. But it seems that's not a big ideal? Is the |
I think it's used for manual build using qubes-builder(v1). Neither builderv2 nor official builds with legacy qubes-builder use this file (the latter use https://github.com/QubesOS/qubes-template-configs/blob/master/R4.1/templates-community/whonix-16.conf). |
Quite likely. It's fixed in git. Will re-check in the next template build once #8330 was resolved (QubesOS/qubes-builder-debian#73).
Alright. I'll remove that file now. |
Whonix 17 use full "workstation" and "gateway" names, instead of whort "ws" and "gw" versions. Rename all template name instances. QubesOS/qubes-issues#1778
Three PRs linked above are tested now. |
Whonix 17 templates use full whonix-gateway name. Match them both by whonix-g pattern. QubesOS/qubes-issues#1778
Whonix 17 templates use full whonix-workstation name. Match them both by whonix-w pattern. QubesOS/qubes-issues#1778
Whonix 17 templates use full whonix-workstation name. Match them both by whonix-w pattern. QubesOS/qubes-issues#1778
This rename is done now in R4.2. |
Whonix 17 use full "workstation" and "gateway" names, instead of whort "ws" and "gw" versions. Rename all template name instances, but also rename relevant state files. The only remaining short form is "feature" name, as this is part of API. QubesOS/qubes-issues#1778 (cherry picked from commit dc96dc2)
Whonix 17 templates use full whonix-gateway name. Match them both by whonix-g pattern. QubesOS/qubes-issues#1778 (cherry picked from commit c7653b6)
Whonix 17 templates use full whonix-workstation name. Match them both by whonix-w pattern. QubesOS/qubes-issues#1778 (cherry picked from commit cd97899)
we need to stop using non-intuitive abbreviations, which are:
whonix-ws
->whonix-workstation
whonix-gw
->whonix-gateway
The text was updated successfully, but these errors were encountered: