Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DispVM firewall settings are neither independent nor volatile. #1608

Closed
marmarek opened this issue Jan 13, 2016 · 5 comments
Closed

DispVM firewall settings are neither independent nor volatile. #1608

marmarek opened this issue Jan 13, 2016 · 5 comments
Assignees
@marmarek
Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. r3.0-dom0-stable r3.1-dom0-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 3.1

Comments

@marmarek
Copy link
Member

https://groups.google.com/d/msgid/qubes-users/d7ba0ec8-2e08-4f37-a0b6-a9a7d0330e2b%40googlegroups.com

When I have multiple DispVMs running and change the firewall settings of one, then it affects
ALL of them plus the settings of fedora-23-dvm. This makes the changes also persistent.

I guess VM settings should only apply to exactly one VM. And especially for DispVMs they should
be as volatile as the DispVM.

Does some config file get symlinked instead of copied when creating a new DVM? I didn't do
further research.
@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core P: major Priority: major. Between "default" and "critical" in severity. labels Jan 13, 2016
@marmarek marmarek added this to the Release 3.1 milestone Jan 13, 2016
marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Jan 14, 2016
@marmarek
tests: add a test for proper saving of DispVM firewall rules
f4d46c7 
Test if DispVM firewall rules are:
 - inherited from a calling VM
 - saved properly (so will be effective after firewall reload)
 - saved only for that DispVM (#1608)

QubesOS/qubes-issues#1608
marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Jan 15, 2016
@marmarek
tests: add a test for proper saving of DispVM firewall rules
69f7fdf 
Test if DispVM firewall rules are:
 - inherited from a calling VM
 - saved properly (so will be effective after firewall reload)
 - saved only for that DispVM (#1608)

QubesOS/qubes-issues#1608

(cherry picked from commit f4d46c7)

Conflicts:
	tests/basic.py
@marmarek
Copy link
Member Author

Important condition - fedora-23-dvm needs to have customized firewall rules for this bug to happen.

@marmarek marmarek self-assigned this Jan 18, 2016
marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Jan 20, 2016
@marmarek
tests: "empty" firewall propagation
ce75ba4 
Check if "empty" firewall is also properly propagated.

QubesOS/qubes-issues#1608
@marmarek
Copy link
Member Author

marmarek commented Feb 8, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek
Copy link
Member Author

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Feb 29, 2016
@marmarek
tests: add a test for proper saving of DispVM firewall rules
c442ff5 
Test if DispVM firewall rules are:
 - inherited from a calling VM
 - saved properly (so will be effective after firewall reload)
 - saved only for that DispVM (#1608)

QubesOS/qubes-issues#1608

(cherry picked from commit f4d46c7)
marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Feb 29, 2016
@marmarek
tests: "empty" firewall propagation
4adcfe1 
Check if "empty" firewall is also properly propagated.

QubesOS/qubes-issues#1608

(cherry picked from commit ce75ba4)
marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Feb 29, 2016
@marmarek
dispvm: fix firewall propagation when the calling VM has no rules set
e49698b 
Fixes QubesOS/qubes-issues#1608

(cherry picked from commit 8737064)
@marmarek
Copy link
Member Author

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek
Copy link
Member Author

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marmarek marmarek

Labels
C: core P: major Priority: major. Between "default" and "critical" in severity. r3.0-dom0-stable r3.1-dom0-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 3.1
Development

No branches or pull requests
1 participant
@marmarek