icon-receiver: Retry X connection on error #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative would be to simply exit on X connection error. There is a |
Add an exception handler to the event loop, which will exit if there is a connection error.
rmol
force-pushed
the
5979-icon-receiver-reconnect
branch
from
64bcd7f to
58772f4
Compare
|
That does seem to work better. |
marmarek
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an exception handler to the event loop, which will try to reestablish the xcb connection on error. The connection logic is pulled out of
IconReceiver.__init__to a newconnectmethod, to support this.This does mitigate QubesOS/qubes-issues#5979, but I hesitate to call it a complete fix. What happens for me is that
icon-receiverstill fails to connect for 6-7 seconds, during which time it's still spamming.xsession-errors.old, but it is eventually able to connect and the torrent of error logging stops.