Fix tray icon coloring code - do not crop/dislocate icon fragments #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When only part of the icon was redrawn, the code used wrong coordinates and instead of putting that part back at the correct (x, y) coordinates, it put it at (x, x). Additionally, it used cropped part of that icon, because of again using (x, x) start coordinates (in an image already containing just updated fragment) instead of (0, 0). It worked accidentally only when the application always redraw the whole icon (or at least its top-left part - so x=y=0). Which apparently is a very common thing applications do. Fixes QubesOS/qubes-issues#5704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only part of the icon was redrawn, the code used wrong coordinates
and instead of putting that part back at the correct (x, y) coordinates,
it put it at (x, x). Additionally, it used cropped part of that
icon, because of again using (x, x) start coordinates (in an image already
containing just updated fragment) instead of (0, 0).
It worked accidentally only when the application always redraw the whole
icon (or at least its top-left part - so x=y=0). Which apparently is a
very common thing applications do.
Fixes QubesOS/qubes-issues#5704