Apply suggestions from code review

Co-authored-by: Demi Marie Obenour <[email protected]>
QubesOS · Mar 8, 2022 · 0969c4b · 0969c4b
1 parent a88b25e
commit 0969c4b
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/gui-daemon/xside.c b/gui-daemon/xside.c
@@ -2384,17 +2384,16 @@ static void process_xevent(Ghandles * g)
         XIEvent* xi_event = cookie->data; // from test_xi2.c in xinput cli utility
 
         XIDeviceEvent * xi_device = (XIDeviceEvent *)xi_event;
-        XILeaveEvent * xi_leave = (XILeaveEvent *)xi_event;
         switch (xi_event->evtype) {
         // ideally raw input events are better, but I'm relying on X server's built-in event filtering and routing feature here
         case XI_KeyPress:
         case XI_KeyRelease:
-            if (xi_device && xi_device->flags & XIKeyRepeat) break; // don't send key repeat events
+            if (xi_device && (xi_device->flags & XIKeyRepeat)) break; // don't send key repeat events
             process_xievent_keypress(g, xi_device);
             break;
         case XI_FocusIn:
         case XI_FocusOut:
-            process_xievent_focus(g, xi_leave);
+            process_xievent_focus(g, (XILeaveEvent *)xi_event);
             break;
         }
         XFreeEventData(g->display, cookie);