Avoid leaking file descriptors #83
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly avoids spurious SELinux denials, but it is good practice anyway. Should fix the file descriptor leakage in #5214.
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.1&build=2022021806-4.1&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.1&build=2022021706-4.1&flavor=update
Failed tests2 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/35157#dependencies 21 fixed
Unstable tests
|
marmarek
requested changes
Feb 18, 2022
| errno = 0; | ||
| fd_num = strtol(entry->d_name, &endptr, 10); | ||
| if (errno || !endptr || *endptr || fd_num < 0 || fd_num > INT_MAX) | ||
| errx(1, "bad number in /proc/self/fd"); |
There was a problem hiding this comment.
This always trips, I'm pretty sure it's about . or ...
Anyway, setting all FDs to O_CLOEXEC sounds fragile (there may be cases when inheriting open FD would be desirable, even if currently it isn't used), and also could hide other issues. I'd prefer to do it properly:
- inspect what FDs are currently passed on to children, and for each consciously decide whether
O_CLOEXECis desirable (or maybe it shouldn't be left open at all?) - (optionally) add a test that checks for FD leaks - we do have proper unit tests in this repo, so it shouldn't be too hard. see
qrexec/tests/socket/agent.pyfor example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly avoids spurious SELinux denials, but it is good practice anyway.
Should fix the file descriptor leakage in QubesOS/qubes-issues#5214.