WIP: Support for source domain in RPC service #182
Conversation
|
|
||
| case $0 in (/*) cd "${0%/*}/";; (*/*) cd "./${0%/*}";; esac | ||
| if command -v dnf >/dev/null; then | ||
| sudo dnf install python3dist\({coverage,pytest,gbulb,pyinotify,pytest-asyncio}\) || : | ||
| sudo dnf install python3dist\({coverage,pytest,gbulb,pyinotify,pytest-asyncio}\) qubes-libvchan-xen-devel pam-devel || : |
There was a problem hiding this comment.
Keeping it here for now to not forget packages to install ..
fepitre
force-pushed
the
source-domain
branch
from
3de5847 to
2f0b1db
Compare
| @@ -84,7 +84,7 @@ int handle_daemon_handshake(int fd) | |||
| return -1; | |||
| } | |||
|
|
|||
| if (info.version != QREXEC_PROTOCOL_VERSION) { | |||
| if (info.version < QREXEC_PROTOCOL_V3) { | |||
There was a problem hiding this comment.
Generally, it's not enough to just relax this check. You need to also save which version the daemon is using (V4 is just adding a message that isn't relevant for the qrexec-client, but still). And similarly change in handle_client_hello and also save which client is using what version.
Alternatively, you can keep using V3 for daemon<->client communication, since new message is not needed at this place (right?). This will be also easier to test. But relaxing the check is a good idea for the future anyway (but can be done in a separate PR if you prefer).
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024120313-4.3&flavor=pull-requests Test run included the following:
Installing updates failed, skipping the report! |
fepitre
force-pushed
the
source-domain
branch
2 times, most recently
from
6b54ae9 to
edb805b
Compare
fepitre
force-pushed
the
source-domain
branch
from
edb805b to
809e50a
Compare
QubesOS/qubes-issues/issues/9475