Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare-suspend: do not disable virtual interfaces before suspend #385

Merged
merged 2 commits into from
Aug 12, 2022
Merged

prepare-suspend: do not disable virtual interfaces before suspend #385

merged 2 commits into from
Aug 12, 2022

Conversation

marmarek
Copy link
Member

@marmarek marmarek commented Jun 6, 2022

There is no need to disable virtual (dummy) interfaces before suspend, it
matters only for physical ones. Especially, do not de-configure dummy eth1
used by Whonix, as there is nothing to turn it back on after resume.

QubesOS/qubes-issues#2044
QubesOS/qubes-issues#7404

marmarek added 2 commits June 6, 2022 17:12
@marmarek
prepare-suspend: typo fix
ab3eea3
@marmarek
prepare-suspend: do not disable virtual interfaces before suspend
ce8bfa0 
There is no need to disable virtual (dummy) interfaces before suspend,
it matters only for physical ones. Especially, do not de-configure dummy
eth1 used by Whonix, as there is nothing to turn it back on after
resume.

QubesOS/qubes-issues#2044
QubesOS/qubes-issues#7404
@qubesos-bot
Copy link

qubesos-bot commented Jul 8, 2022 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.1&build=2022072711-4.1&flavor=pull-requests

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.1&build=2022071906-4.1&flavor=update

  • system_tests_network_updates

    • TC_11_QvmTemplateMgmtVM_debian-11: test_000_template_list (failure)
      AssertionError: libvirt event impl drain timeout

  • system_tests_basic_vm_qrexec_gui_btrfs

Failed tests

17 failures

  • system_tests_network_updates

    • [unstable] TC_10_QvmTemplate_whonix-gw-16: test_010_template_install (error)
      subprocess.CalledProcessError: Command 'systemcheck --cli' returned...

    • TC_11_QvmTemplateMgmtVM_debian-11: test_000_template_list (failure)
      AssertionError: libvirt event impl drain timeout

    • [unstable] TC_11_QvmTemplateMgmtVM_whonix-gw-16: test_010_template_install (error)
      subprocess.CalledProcessError: Command 'systemcheck --cli' returned...

  • system_tests_dispvm

    • [unstable] TC_20_DispVM_fedora-36: test_100_open_in_dispvm (failure)
      self.assertEqual(test_txt_content.s... AssertionError: b'' != b'test1'

    • [unstable] TC_20_DispVM_whonix-ws-16: test_100_open_in_dispvm (failure)
      AssertionError: libvirt event impl drain timeout

  • system_tests_basic_vm_qrexec_gui_btrfs

  • system_tests_basic_vm_qrexec_gui@hw1

  • system_tests_extra

    • [unstable] TC_00_InputProxy_fedora-36: test_050_mouse_late_attach (failure)
      AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

  • system_tests_suspend@hw1

    • [unstable] suspend: wait_serial (wait serial expected)
      # wait_serial expected: qr/p5~T5-\d+-/...

    • [unstable] suspend: Failed (test died + timed out)
      # Test died: command 'true' timed out at qubesos/tests/suspend.pm l...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/44309#dependencies

22 fixed

Unstable tests

  • system_tests_gui_tools

    qubesmanager_vmsettings/Failed (1/5 times with errors)
    • job 44351 # Test died: Odd name/value argument for subroutine 'testapi::asser...

  • system_tests_basic_vm_qrexec_gui

    TC_30_Gui_daemon/test_000_clipboard (1/5 times with errors)
    • job 44349 self.assertEqual(clipboard_content, ... AssertionError: '' != 'test19'

  • system_tests_pvgrub_salt_storage

    TC_41_HVMGrub_debian-11/test_000_standalone_vm (1/5 times with errors)
    • job 43833 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 90 secon...
    TC_42_PVHGrub_debian-11/test_000_standalone_vm (1/5 times with errors)
    • job 43833 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 90 secon...
    TC_41_HVMGrub_debian-11/test_010_template_based_vm (1/5 times with errors)
    • job 43833 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 90 secon...
    TC_41_HVMGrub_fedora-36/test_010_template_based_vm (1/5 times with errors)
    • job 43833 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 90 secon...
    TC_42_PVHGrub_debian-11/test_010_template_based_vm (1/5 times with errors)
    • job 43833 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 90 secon...

  • system_tests_splitgpg

    TC_10_Thunderbird_debian-11/test_000_send_receive_default (2/5 times with errors)
    • job 43834 Exception: Failed to send message with error 'unknown'
    • job 43877 dogtail.tree.SearchError: child of [desktop frame | main]: "Thunder...
    TC_10_Thunderbird_fedora-36/test_000_send_receive_default (2/5 times with errors)
    • job 43834 dogtail.tree.SearchError: descendent of [menu bar | Application]: c...
    • job 43877 dogtail.tree.SearchError: child of [desktop frame | main]: "Thunder...
    TC_10_Thunderbird_debian-11/test_010_send_receive_inline_signed_only (1/5 times with errors)
    • job 43877 dogtail.tree.SearchError: child of [desktop frame | main]: "Thunder...
    TC_10_Thunderbird_fedora-36/test_010_send_receive_inline_signed_only (2/5 times with errors)
    • job 43834 dogtail.tree.SearchError: descendent of [menu bar | Application]: c...
    • job 43877 dogtail.tree.SearchError: child of [desktop frame | main]: "Thunder...
    TC_10_Thunderbird_debian-11/test_020_send_receive_inline_with_attachment (1/5 times with errors)
    • job 43834 dogtail.tree.SearchError: descendent of [application | Thunderbird]...
    TC_10_Thunderbird_fedora-36/test_020_send_receive_inline_with_attachment (2/5 times with errors)
    • job 43834 dogtail.tree.SearchError: descendent of [menu bar | Application]: c...
    • job 43877 dogtail.tree.SearchError: child of [desktop frame | main]: "Thunder...

  • system_tests_guivm_gui_interactive

    gui_keyboard_layout/ (1/3 times with errors)
    gui_keyboard_layout/ (1/3 times with errors)
    gui_keyboard_layout/Failed (1/3 times with errors)
    • job 44377 # Test died: no candidate needle with tag(s) 'work-xterm, work-xter...
    gui_keyboard_layout/Failed (1/3 times with errors)
    • job 44379 # Test died: no candidate needle with tag(s) 'work-xterm, work-xter...

  • system_tests_usbproxy

    TC_20_USBProxy_core3_whonix-gw-16/test_070_attach_not_installed_front (1/5 times with errors)
    • job 42965 qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...

  • system_tests_qrexec

    TC_00_Qrexec_debian-11/test_050_qrexec_simple_eof (1/5 times with errors)
    • job 43856 AssertionError: Timeout, probably EOF wasn't transferred to the VM ...
    TC_00_Qrexec_debian-11/test_090_qrexec_service_socket_dom0 (1/5 times with errors)
    • job 42973 AssertionError: service timeout, probably EOF wasn't transferred to...

  • system_tests_network_ipv6

    VmIPv6Networking_debian-11/test_020_simple_proxyvm_nm (1/5 times with errors)
    • job 44367 AssertionError: 1 != 0 : nm-applet window not found
    VmIPv6Networking_debian-11/test_520_ipv6_simple_proxyvm_nm (1/5 times with errors)
    • job 44367 AssertionError: 1 != 0 : nm-applet window not found
    VmIPv6Networking_debian-11/test_540_ipv6_inter_vm (1/5 times with errors)
    • job 43248 raise exceptions.TimeoutError()... asyncio.exceptions.TimeoutError

  • system_tests_network_updates

    TC_11_QvmTemplateMgmtVM_whonix-gw-16/test_000_template_list (2/5 times with errors)
    • job 43832 AssertionError: libvirt event impl drain timeout
    • job 44355 AssertionError: libvirt event impl drain timeout
    TC_10_QvmTemplate_whonix-gw-16/test_010_template_install (1/5 times with errors)
    • job 44355 AssertionError: qvm-template failed: Downloading 'qubes-template-de...
    TC_11_QvmTemplateMgmtVM_debian-11/test_010_template_install (2/5 times with errors)
    • job 42602 AssertionError: libvirt event impl drain timeout
    • job 44355 AssertionError: libvirt event impl drain timeout
    TC_11_QvmTemplateMgmtVM_whonix-gw-16/test_010_template_install (1/5 times with errors)
    • job 44355 AssertionError: qvm-template failed: Downloading 'qubes-template-de...
    TC_11_QvmTemplateMgmtVM_whonix-ws-16/test_010_template_install (1/5 times with errors)

  • system_tests_dispvm

    TC_20_DispVM_debian-11/test_010_simple_dvm_run (1/5 times with errors)
    • job 43841 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 90 secon...
    TC_20_DispVM_fedora-36/test_010_simple_dvm_run (1/5 times with errors)
    • job 43841 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_20_DispVM_whonix-gw-16/test_010_simple_dvm_run (1/5 times with errors)
    TC_20_DispVM_whonix-ws-16/test_010_simple_dvm_run (1/5 times with errors)
    • job 43841 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 90 secon...
    TC_20_DispVM_debian-11/test_020_gui_app (1/5 times with errors)
    • job 43841 raise exceptions.TimeoutError()... asyncio.exceptions.TimeoutError
    TC_20_DispVM_whonix-gw-16/test_020_gui_app (1/5 times with errors)
    TC_20_DispVM_debian-11/test_030_edit_file (1/5 times with errors)
    • job 43841 AssertionError: Timeout while waiting for disp[0-9]* window to show
    TC_20_DispVM_fedora-36/test_030_edit_file (4/5 times with errors)
    • job 42967 AssertionError: Timeout waiting for editor window
    • job 43255 AssertionError: Timeout waiting for editor window
    • job 43841 AssertionError: Timeout while waiting for disp[0-9]* window to show
    • job 44312 AssertionError: Timeout waiting for editor window
    TC_20_DispVM_whonix-gw-16/test_030_edit_file (1/5 times with errors)
    TC_20_DispVM_whonix-ws-16/test_030_edit_file (1/5 times with errors)
    • job 43841 AssertionError: Timeout while waiting for disp[0-9]* window to show
    TC_20_DispVM_debian-11/test_100_open_in_dispvm (1/5 times with errors)
    • job 43841 AssertionError: './open-file test.txt' failed with ./open-file test...
    TC_20_DispVM_fedora-36/test_100_open_in_dispvm (4/5 times with errors)
    • job 42967 AssertionError: Timeout waiting for editor window
    • job 43255 AssertionError: Timeout waiting for editor window
    • job 43841 AssertionError: './open-file test.txt' failed with ./open-file test...
    • job 44312 AssertionError: Timeout waiting for editor window
    TC_20_DispVM_whonix-gw-16/test_100_open_in_dispvm (1/5 times with errors)
    TC_20_DispVM_whonix-ws-16/test_100_open_in_dispvm (5/5 times with errors)
    • job 42626 AssertionError: libvirt event impl drain timeout
    • job 42967 AssertionError: libvirt event impl drain timeout
    • job 43255 AssertionError: libvirt event impl drain timeout
    • job 43841 AssertionError: './open-file test.txt' failed with ./open-file test...
    • job 44312 AssertionError: libvirt event impl drain timeout

  • system_tests_devices

    TC_10_Attach_debian-11/test_000_attach_reattach (3/5 times with errors)
    • job 42968 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    • job 43816 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    • job 44313 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    TC_10_Attach_fedora-36/test_000_attach_reattach (3/5 times with errors)
    • job 42968 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    • job 43816 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    • job 44313 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    TC_10_Attach_whonix-gw-16/test_000_attach_reattach (3/5 times with errors)
    • job 42968 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    • job 43816 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    • job 44313 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    TC_10_Attach_whonix-ws-16/test_000_attach_reattach (3/5 times with errors)
    • job 42968 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    • job 43816 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...
    • job 44313 subprocess.CalledProcessError: Command 'ls /dev/xvdi' returned non-...

  • system_tests_basic_vm_qrexec_gui_btrfs

    TC_00_AppVM_whonix-gw-16-pool/test_000_start_shutdown (1/5 times with errors)
    • job 43019 qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...
    TC_00_AppVM_debian-11-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44624 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_00_AppVM_fedora-36-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44624 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_00_AppVM_whonix-gw-16-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44624 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_00_AppVM_whonix-ws-16-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44624 assert len(self.loop._selector.get_map()) \... AssertionError

  • system_tests_basic_vm_qrexec_gui_xfs

    TC_00_AppVM_debian-11-pool/test_223_audio_play_hvm (1/5 times with errors)
    • job 44317 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_00_AppVM_whonix-ws-16-pool/test_225_audio_rec_unmuted_hvm (1/5 times with errors)
    • job 43010 AssertionError: only silence detected, no useful audio data
    TC_00_AppVM_debian-11-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44317 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_00_AppVM_fedora-36-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44317 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_00_AppVM_whonix-gw-16-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44317 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_00_AppVM_whonix-ws-16-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44317 assert len(self.loop._selector.get_map()) \... AssertionError

  • system_tests_basic_vm_qrexec_gui@hw1

    TC_30_Gui_daemon/test_000_clipboard (1/5 times with errors)
    • job 44349 self.assertEqual(clipboard_content, ... AssertionError: '' != 'test19'

  • system_tests_gui_tools@hw1

    qubesmanager_vmsettings/Failed (1/5 times with errors)
    • job 44351 # Test died: Odd name/value argument for subroutine 'testapi::asser...

  • system_tests_extra

    TC_00_InputProxy_debian-11/test_050_mouse_late_attach (1/5 times with errors)
    • job 44323 AssertionError: unexpectedly None : Device 'test-inst-input: Test i...
    TC_00_InputProxy_fedora-36/test_050_mouse_late_attach (1/5 times with errors)
    • job 44323 AssertionError: unexpectedly None : Device 'test-inst-input: Test i...

  • system_tests_suspend

    suspend/ (1/5 times with errors)
    suspend/Failed (1/5 times with errors)
    • job 44654 # Test died: no candidate needle with tag(s) 'xscreensaver-prompt' ...
    suspend/wait_serial (1/5 times with errors)
    • job 44654 # wait_serial expected: "xl info; echo 8Ye1l-\$?-"...
    suspend/wait_serial (1/5 times with errors)
    • job 44654 # wait_serial expected: qr/8Ye1l-\d+-/...

  • system_tests_suspend@hw1

    suspend/ (1/5 times with errors)
    suspend/Failed (1/5 times with errors)
    • job 44654 # Test died: no candidate needle with tag(s) 'xscreensaver-prompt' ...
    suspend/wait_serial (1/5 times with errors)
    • job 44654 # wait_serial expected: "xl info; echo 8Ye1l-\$?-"...
    suspend/wait_serial (1/5 times with errors)
    • job 44654 # wait_serial expected: qr/8Ye1l-\d+-/...

  • system_tests_basic_vm_qrexec_gui_ext4

    TC_00_AppVM_debian-11-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44350 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_00_AppVM_fedora-36-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44350 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_00_AppVM_whonix-gw-16-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44350 assert len(self.loop._selector.get_map()) \... AssertionError
    TC_00_AppVM_whonix-ws-16-pool/test_300_bug_1028_gui_memory_pinning (1/5 times with errors)
    • job 44350 assert len(self.loop._selector.get_map()) \... AssertionError

@marmarek marmarek merged commit ac42e17 into QubesOS:master Aug 12, 2022
@marmarek marmarek deleted the suspend-all-fix branch October 24, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
openqa-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marmarek @qubesos-bot