-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve checking for memory hotplug support and ease pvgrub usage #586
Conversation
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024042404-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024041501-4.2&flavor=update
Failed tests33 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/97064#dependencies 7 fixed
Unstable tests
|
1. Fix handling HVM to match the intention described in the comment. 2. Fix distinguishing dom0-provided and vm-provided kernels - the actual "kernel" property value depends on the virt_mode QubesOS/qubes-issues#7956
No behavior change intended, but will ease further changes.
Do not require initramfs in dom0-provided kernel. This is especially useful for unikernels, but some full OS might not require initramfs either. Stop requiring dummy file. Fixes QubesOS/qubes-issues#5516
Mock a kernels directory, similar as in libvirt xml tests.
Automatically translate it to appropriate pvgrub flavor. QubesOS/qubes-issues#5212
8121cb0
to
ba8bc65
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
==========================================
+ Coverage 68.51% 68.57% +0.05%
==========================================
Files 56 56
Lines 11196 11222 +26
==========================================
+ Hits 7671 7695 +24
- Misses 3525 3527 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
"kernel" property value depends on the
virt_mode
While at it, make kernel "none" use in-vm kernel for PV and PVH too - translating automatically to appropriate pvgrub flavor. And make initramfs really optional.
QubesOS/qubes-issues#7956
QubesOS/qubes-issues#5212
QubesOS/qubes-issues#5516