Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checking for memory hotplug support and ease pvgrub usage #586

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

marmarek
Copy link
Member

@marmarek marmarek commented Apr 20, 2024

  1. Fix handling HVM to match the intention described in the comment.
  2. Fix distinguishing dom0-provided and vm-provided kernels - the actual
    "kernel" property value depends on the virt_mode

While at it, make kernel "none" use in-vm kernel for PV and PVH too - translating automatically to appropriate pvgrub flavor. And make initramfs really optional.

QubesOS/qubes-issues#7956
QubesOS/qubes-issues#5212
QubesOS/qubes-issues#5516

@qubesos-bot
Copy link

qubesos-bot commented Apr 20, 2024

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024042404-4.2&flavor=pull-requests

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024041501-4.2&flavor=update

  • system_tests_basic_vm_qrexec_gui

  • system_tests_network_updates

    • TC_11_QvmTemplateMgmtVM_debian-12-xfce: test_000_template_list (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_11_QvmTemplateMgmtVM_debian-12-xfce: test_010_template_install (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_11_QvmTemplateMgmtVM_fedora-39-xfce: test_000_template_list (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_11_QvmTemplateMgmtVM_whonix-gateway-17: test_000_template_list (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_11_QvmTemplateMgmtVM_whonix-gateway-17: test_010_template_install (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

Failed tests

33 failures
  • system_tests_basic_vm_qrexec_gui

  • system_tests_pvgrub_salt_storage

    • TC_41_HVMGrub_fedora-39-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_41_HVMGrub_fedora-39-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_splitgpg

  • system_tests_dispvm

    • [unstable] TC_20_DispVM_fedora-39-xfce: test_100_open_in_dispvm (failure)
      AssertionError: Timeout waiting for editor window
  • system_tests_basic_vm_qrexec_gui_zfs

  • system_tests_basic_vm_qrexec_gui_ext4

  • system_tests_basic_vm_qrexec_gui_xfs

  • system_tests_basic_vm_qrexec_gui@hw1

  • system_tests_basic_vm_qrexec_gui_btrfs

  • system_tests_network_updates

    • [unstable] TC_10_QvmTemplate_whonix-gateway-17: test_010_template_install (failure)
      AssertionError: libvirt event impl drain timeout

    • TC_11_QvmTemplateMgmtVM_debian-12-xfce: test_000_template_list (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_11_QvmTemplateMgmtVM_debian-12-xfce: test_010_template_install (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_11_QvmTemplateMgmtVM_fedora-39-xfce: test_000_template_list (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • [unstable] TC_11_QvmTemplateMgmtVM_fedora-39-xfce: test_010_template_install (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_11_QvmTemplateMgmtVM_whonix-gateway-17: test_000_template_list (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

    • TC_11_QvmTemplateMgmtVM_whonix-gateway-17: test_010_template_install (failure + cleanup)
      ^^^^^^^^^^^^^^^^^^^^^^... AssertionError

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/97064#dependencies

7 fixed
  • system_tests_pvgrub_salt_storage

    • TC_41_HVMGrub_debian-12-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_41_HVMGrub_debian-12-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_42_PVHGrub_fedora-39-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_42_PVHGrub_fedora-39-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_network_ipv6

  • system_tests_basic_vm_qrexec_gui_xfs

Unstable tests

  • system_tests_basic_vm_qrexec_gui

    TC_20_AudioVM_Pulse_debian-12-xfce/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 94385 AssertionError: too short audio, expected 10s, got 8.26902494331065...
    • job 95164 AssertionError: too short audio, expected 10s, got 9.06335600907029...
    TC_20_AudioVM_Pulse_fedora-39-xfce/test_220_audio_play_pulseaudio (1/5 times with errors)
    • job 94385 AssertionError: too short audio, expected 10s, got 8.97528344671201...
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_220_audio_play_pulseaudio (5/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96347 AssertionError: only silence detected, no useful audio data
    • job 97080 AssertionError: only silence detected, no useful audio data
    • job 97185 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_221_audio_rec_muted_pulseaudio (2/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_222_audio_rec_unmuted_pulseaudio (5/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96347 AssertionError: only silence detected, no useful audio data
    • job 97080 AssertionError: only silence detected, no useful audio data
    • job 97185 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_223_audio_play_hvm (2/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_224_audio_rec_muted_hvm (2/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_225_audio_rec_unmuted_hvm (2/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_PipeWire_debian-12-xfce/test_226_audio_playback_pipewire (2/5 times with errors)
    • job 94385 AssertionError: too short audio, expected 10s, got 9.34784580498866...
    • job 95164 AssertionError: too short audio, expected 10s, got 9.49097505668934...
  • system_tests_pvgrub_salt_storage

    TC_41_HVMGrub_debian-12-xfce/test_000_standalone_vm (3/5 times with errors)
    • job 96359 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 97092 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 97197 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    TC_41_HVMGrub_debian-12-xfce/test_010_template_based_vm (3/5 times with errors)
    • job 96359 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 97092 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
    • job 97197 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
  • system_tests_extra

    TC_00_QVCTest_debian-12-xfce/test_010_screenshare (1/5 times with errors)
    • job 94380 ^^^^^^^^^^^^^^^^^^^^^^... AssertionError
    TC_00_QVCTest_fedora-39-xfce/test_010_screenshare (1/5 times with errors)
    • job 94380 ^^^^^^^^^^^^^^^^^^^^^^... AssertionError
    TC_00_QVCTest_whonix-gateway-17/test_010_screenshare (1/5 times with errors)
    • job 94380 AssertionError: 'qubes-video-companion screenshare' exited early (1...
    TC_00_QVCTest_whonix-workstation-17/test_010_screenshare (1/5 times with errors)
    • job 94380 AssertionError: 'qubes-video-companion screenshare' exited early (1...
    TC_00_QVCTest_debian-12-xfce/test_020_webcam (1/5 times with errors)
    • job 94380 ^^^^^^^^^^^^^^^^^^^^^^... AssertionError
    TC_00_QVCTest_fedora-39-xfce/test_020_webcam (1/5 times with errors)
    • job 94380 ~~~~^~~~~~~~~~... ZeroDivisionError: division by zero
    TC_00_QVCTest_whonix-gateway-17/test_020_webcam (1/5 times with errors)
    • job 94380 self.assertIsNone(p.returncode)... AssertionError: 1 is not None
    TC_00_QVCTest_whonix-workstation-17/test_020_webcam (1/5 times with errors)
    • job 94380 self.assertIsNone(p.returncode)... AssertionError: 1 is not None
    TC_00_Appmenus/test_121_create_appvm_with_whitelist (1/5 times with errors)
    • job 94380 '/tmp/tmpb0w885he/test-inst-app/apps/org.qubes-os.qubes-vm-setting...
  • system_tests_usbproxy

    TC_20_USBProxy_core3_debian-12-xfce/test_030_detach (1/5 times with errors)
    • job 95187 AssertionError: 0 == 0 : Device disconnection failed
    TC_20_USBProxy_core3_whonix-gateway-17/test_070_attach_not_installed_front (1/5 times with errors)
    • job 97173 qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...
    TC_20_USBProxy_core3_debian-12-xfce/test_090_attach_stubdom (1/5 times with errors)
    • job 97608 AssertionError: 1 != 0 : Device connection failed
    TC_20_USBProxy_core3_fedora-39-xfce/test_090_attach_stubdom (1/5 times with errors)
    • job 97608 AssertionError: 1 != 0 : Device connection failed
  • system_tests_network_ipv6

    VmIPv6Networking_debian-12-xfce/test_031_firewall_dynamic_block (1/5 times with errors)
    • job 97090 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
    VmIPv6Networking_fedora-39-xfce/test_031_firewall_dynamic_block (2/5 times with errors)
    • job 96357 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
    • job 97090 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
  • system_tests_dispvm

    TC_20_DispVM_fedora-39-xfce/test_100_open_in_dispvm (1/5 times with errors)
    • job 94390 AssertionError: './open-file test.txt' failed with ./open-file test...
  • system_tests_devices

    TC_00_List_debian-12-xfce/test_001_list_loop_mounted (1/5 times with errors)
    • job 96351 AssertionError: Device test-inst-vm:loop0 (/tmp/test.img) should no...
  • system_tests_basic_vm_qrexec_gui_zfs

    TC_00_Basic/test_120_start_standalone_with_cdrom_dom0 (1/5 times with errors)
    • job 95180 AssertionError: 1 != 0 : b'Timeout waiting for dom0:loop4 device to...
    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 94379 AssertionError: Command 'paplay --format=float32le --rate=44100 --c...
    • job 95180 AssertionError: too short audio, expected 10s, got 8.96707482993197...
    TC_20_AudioVM_Pulse_fedora-39-xfce-pool/test_220_audio_play_pulseaudio (1/5 times with errors)
    • job 95180 AssertionError: too short audio, expected 10s, got 8.61614512471655...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_220_audio_play_pulseaudio (5/5 times with errors)
    • job 94379 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95180 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96337 AssertionError: only silence detected, no useful audio data
    • job 97096 AssertionError: only silence detected, no useful audio data
    • job 97175 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_221_audio_rec_muted_pulseaudio (2/5 times with errors)
    • job 94379 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95180 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_222_audio_rec_unmuted_pulseaudio (5/5 times with errors)
    • job 94379 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95180 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96337 AssertionError: only silence detected, no useful audio data
    • job 97096 AssertionError: only silence detected, no useful audio data
    • job 97175 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_fedora-39-xfce-pool/test_223_audio_play_hvm (1/5 times with errors)
    • job 95180 AssertionError: frequency 3517.990148595454 not in specified range,...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_223_audio_play_hvm (2/5 times with errors)
    • job 94379 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95180 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_224_audio_rec_muted_hvm (2/5 times with errors)
    • job 94379 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95180 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_225_audio_rec_unmuted_hvm (2/5 times with errors)
    • job 94379 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95180 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
  • system_tests_basic_vm_qrexec_gui_ext4

    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 94268 AssertionError: too short audio, expected 10s, got 8.77791383219954...
    • job 95166 AssertionError: too short audio, expected 10s, got 9.13657596371882...
    TC_20_AudioVM_Pulse_fedora-39-xfce-pool/test_220_audio_play_pulseaudio (1/5 times with errors)
    • job 95166 AssertionError: too short audio, expected 10s, got 9.01439909297052...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_220_audio_play_pulseaudio (5/5 times with errors)
    • job 94268 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95166 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96349 AssertionError: only silence detected, no useful audio data
    • job 97082 AssertionError: only silence detected, no useful audio data
    • job 97187 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_221_audio_rec_muted_pulseaudio (2/5 times with errors)
    • job 94268 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95166 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_222_audio_rec_unmuted_pulseaudio (5/5 times with errors)
    • job 94268 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95166 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96349 AssertionError: only silence detected, no useful audio data
    • job 97082 AssertionError: only silence detected, no useful audio data
    • job 97187 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_223_audio_play_hvm (2/5 times with errors)
    • job 94268 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95166 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_224_audio_rec_muted_hvm (2/5 times with errors)
    • job 94268 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95166 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_225_audio_rec_unmuted_hvm (2/5 times with errors)
    • job 94268 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95166 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_PipeWire_fedora-39-xfce-pool/test_226_audio_playback_pipewire (2/5 times with errors)
    • job 94268 AssertionError: too short audio, expected 10s, got 9.14578231292517...
    • job 95166 AssertionError: too short audio, expected 10s, got 9.48775510204081...
  • system_tests_basic_vm_qrexec_gui_xfs

    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_220_audio_play_pulseaudio (3/5 times with errors)
    • job 94192 AssertionError: too short audio, expected 10s, got 9.48453514739229...
    • job 94388 AssertionError: too short audio, expected 10s, got 9.32911564625850...
    • job 95167 AssertionError: too short audio, expected 10s, got 8.98888888888888...
    TC_20_AudioVM_Pulse_fedora-39-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 94192 AssertionError: too short audio, expected 10s, got 9.49594104308390...
    • job 94388 AssertionError: too short audio, expected 10s, got 8.73632653061224...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_220_audio_play_pulseaudio (5/5 times with errors)
    • job 94192 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 94388 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95167 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 97083 AssertionError: only silence detected, no useful audio data
    • job 97188 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_221_audio_rec_muted_pulseaudio (3/5 times with errors)
    • job 94192 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 94388 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95167 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_222_audio_rec_unmuted_pulseaudio (2/5 times with errors)
    • job 94388 AssertionError: only silence detected, no useful audio data
    • job 97083 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_222_audio_rec_unmuted_pulseaudio (5/5 times with errors)
    • job 94192 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 94388 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95167 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 97083 AssertionError: only silence detected, no useful audio data
    • job 97188 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_223_audio_play_hvm (3/5 times with errors)
    • job 94192 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 94388 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95167 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_224_audio_rec_muted_hvm (3/5 times with errors)
    • job 94192 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 94388 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95167 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_225_audio_rec_unmuted_hvm (3/5 times with errors)
    • job 94192 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 94388 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95167 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_PipeWire_debian-12-xfce-pool/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 95167 AssertionError: too short audio, expected 10s, got 9.48408163265306...
    TC_20_AudioVM_PipeWire_fedora-39-xfce-pool/test_226_audio_playback_pipewire (2/5 times with errors)
    • job 94388 AssertionError: too short audio, expected 10s, got 9.47580498866213...
    • job 95167 AssertionError: too short audio, expected 10s, got 9.47213151927437...
  • system_tests_basic_vm_qrexec_gui@hw1

    TC_20_AudioVM_Pulse_debian-12-xfce/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 94385 AssertionError: too short audio, expected 10s, got 8.26902494331065...
    • job 95164 AssertionError: too short audio, expected 10s, got 9.06335600907029...
    TC_20_AudioVM_Pulse_fedora-39-xfce/test_220_audio_play_pulseaudio (1/5 times with errors)
    • job 94385 AssertionError: too short audio, expected 10s, got 8.97528344671201...
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_220_audio_play_pulseaudio (5/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96347 AssertionError: only silence detected, no useful audio data
    • job 97080 AssertionError: only silence detected, no useful audio data
    • job 97185 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_221_audio_rec_muted_pulseaudio (2/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_222_audio_rec_unmuted_pulseaudio (5/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96347 AssertionError: only silence detected, no useful audio data
    • job 97080 AssertionError: only silence detected, no useful audio data
    • job 97185 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_223_audio_play_hvm (2/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_224_audio_rec_muted_hvm (2/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17/test_225_audio_rec_unmuted_hvm (2/5 times with errors)
    • job 94385 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95164 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_PipeWire_debian-12-xfce/test_226_audio_playback_pipewire (2/5 times with errors)
    • job 94385 AssertionError: too short audio, expected 10s, got 9.34784580498866...
    • job 95164 AssertionError: too short audio, expected 10s, got 9.49097505668934...
  • system_tests_basic_vm_qrexec_gui_btrfs

    TC_20_AudioVM_Pulse_debian-12-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 94386 AssertionError: too short audio, expected 10s, got 9.32555555555555...
    • job 95165 AssertionError: too short audio, expected 10s, got 8.28539682539682...
    TC_20_AudioVM_Pulse_fedora-39-xfce-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
    • job 94386 AssertionError: too short audio, expected 10s, got 9.21634920634920...
    • job 95165 AssertionError: too short audio, expected 10s, got 9.25759637188208...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_220_audio_play_pulseaudio (5/5 times with errors)
    • job 94386 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95165 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96348 AssertionError: only silence detected, no useful audio data
    • job 97081 AssertionError: only silence detected, no useful audio data
    • job 97186 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_221_audio_rec_muted_pulseaudio (2/5 times with errors)
    • job 94386 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95165 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_222_audio_rec_unmuted_pulseaudio (5/5 times with errors)
    • job 94386 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95165 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 96348 AssertionError: only silence detected, no useful audio data
    • job 97081 AssertionError: only silence detected, no useful audio data
    • job 97186 AssertionError: only silence detected, no useful audio data
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_223_audio_play_hvm (2/5 times with errors)
    • job 94386 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95165 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_224_audio_rec_muted_hvm (2/5 times with errors)
    • job 94386 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95165 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_Pulse_whonix-workstation-17-pool/test_225_audio_rec_unmuted_hvm (2/5 times with errors)
    • job 94386 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    • job 95165 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
    TC_20_AudioVM_PipeWire_fedora-39-xfce-pool/test_226_audio_playback_pipewire (1/5 times with errors)
    • job 94386 AssertionError: too short audio, expected 10s, got 7.64335600907029...
  • system_tests_network_updates

    TC_10_QvmTemplate_whonix-gateway-17/test_010_template_install (1/5 times with errors)
    • job 97201 AssertionError: libvirt event impl drain timeout
    TC_11_QvmTemplateMgmtVM_fedora-39-xfce/test_010_template_install (1/5 times with errors)
    • job 96358 AssertionError: libvirt event impl drain timeout

1. Fix handling HVM to match the intention described in the comment.
2. Fix distinguishing dom0-provided and vm-provided kernels - the actual
   "kernel" property value depends on the virt_mode

QubesOS/qubes-issues#7956
No behavior change intended, but will ease further changes.
Do not require initramfs in dom0-provided kernel. This is especially
useful for unikernels, but some full OS might not require initramfs
either. Stop requiring dummy file.

Fixes QubesOS/qubes-issues#5516
Mock a kernels directory, similar as in libvirt xml tests.
@marmarek marmarek force-pushed the pvgrub-and-memhotplug branch from 8121cb0 to ba8bc65 Compare April 24, 2024 02:45
@marmarek marmarek changed the title Improve checking for memory hotplug support Improve checking for memory hotplug support and ease pvgrub usage Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.57%. Comparing base (ec10371) to head (ba8bc65).

Files Patch % Lines
qubes/vm/qubesvm.py 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
+ Coverage   68.51%   68.57%   +0.05%     
==========================================
  Files          56       56              
  Lines       11196    11222      +26     
==========================================
+ Hits         7671     7695      +24     
- Misses       3525     3527       +2     
Flag Coverage Δ
unittests 68.57% <89.65%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmarek marmarek merged commit ba8bc65 into QubesOS:main Apr 25, 2024
3 of 4 checks passed
@marmarek marmarek deleted the pvgrub-and-memhotplug branch June 16, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants