dom0-update: do not show xterm with update check process

[marmarek]

This may mess with exit code (critical for setting updates-available
flag), but also may be confusing when started from cron.

This is the last part of dom0 updates notification fix.

Fixes QubesOS/qubes-issues#7437

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.1&build=2022041501-4.1&flavor=pull-requests

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.1&build=2022031706-4.1&flavor=update

• system_tests_network_ipv6

  • VmIPv6Networking_debian-11: test_540_ipv6_inter_vm (error)
    raise exceptions.TimeoutError()... asyncio.exceptions.TimeoutError

• system_tests_basic_vm_qrexec_gui_btrfs

  • TC_00_AppVM_fedora-34-pool: test_225_audio_rec_unmuted_hvm (failure)
    AssertionError: only silence detected, no useful audio data

• system_tests_basic_vm_qrexec_gui_ext4

  • TC_00_AppVM_debian-11-pool: test_225_audio_rec_unmuted_hvm (failure)
    AssertionError: only silence detected, no useful audio data

Failed tests

13 failures

• system_tests_basic_vm_qrexec_gui@hw1

  • TC_00_AppVM_debian-11: test_224_audio_rec_muted_hvm (failure)
    AssertionError: Timeout waiting for pulseaudio start in test-inst-v...

• system_tests_suspend@hw1

  • suspend: wait_serial (wait serial expected)
    # wait_serial expected: qr/p5~T5-\d+-/u...

  • suspend: Failed (test died + timed out)
    # Test died: command 'true' timed out at qubesos/tests/suspend.pm l...

• system_tests_pvgrub_salt_storage

  • TC_40_PVGrub_debian-11: test_000_standalone_vm (error + timed out)
    qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...

  • TC_40_PVGrub_debian-11: test_010_template_based_vm (error + timed out)
    qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...

• system_tests_network_ipv6

  • VmIPv6Networking_debian-11: test_540_ipv6_inter_vm (error)
    raise exceptions.TimeoutError()... asyncio.exceptions.TimeoutError

• system_tests_dispvm

  • [unstable] TC_20_DispVM_debian-11: test_100_open_in_dispvm (failure)
    AssertionError: './open-file test.txt' failed with ./open-file test...

  • [unstable] TC_20_DispVM_whonix-ws-16: test_100_open_in_dispvm (failure)
    AssertionError: libvirt event impl drain timeout

• system_tests_basic_vm_qrexec_gui_btrfs

  • [unstable] TC_30_Gui_daemon: test_000_clipboard (failure)
    self.assertEqual(clipboard_content, ... AssertionError: '' != 'test24'

  • TC_00_AppVM_fedora-34-pool: test_225_audio_rec_unmuted_hvm (failure)
    AssertionError: only silence detected, no useful audio data

• system_tests_basic_vm_qrexec_gui_ext4

  • TC_03_QvmRevertTemplateChanges: test_000_revert_linux (error)
    NotImplementedError: FileVolume supports maximum 1 volume revision ...

  • TC_00_AppVM_debian-11-pool: test_225_audio_rec_unmuted_hvm (failure)
    AssertionError: only silence detected, no useful audio data

• system_tests_network_updates

  • [unstable] TC_10_QvmTemplate_whonix-gw-16: test_010_template_install (failure)
    AssertionError: libvirt event impl drain timeout

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/36922#dependencies

3 fixed

• system_tests_basic_vm_qrexec_gui@hw1

  • TC_00_AppVM_debian-11: test_224_audio_rec_muted_hvm (failure)
    AssertionError: Timeout waiting for pulseaudio start in test-inst-v...

• system_tests_pvgrub_salt_storage

  • TC_40_PVGrub_debian-11: test_000_standalone_vm (error + timed out)
    qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...

  • TC_40_PVGrub_debian-11: test_010_template_based_vm (error + timed out)
    qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...

Unstable tests

• system_tests_basic_vm_qrexec_gui@hw1

  TC_30_Gui_daemon/test_000_clipboard (1/5 times with errors)

  • job 37531 FileNotFoundError: [Errno 2] No such file or directory: '/var/run/q...

• system_tests_basic_vm_qrexec_gui

  TC_30_Gui_daemon/test_000_clipboard (1/5 times with errors)

  • job 37531 FileNotFoundError: [Errno 2] No such file or directory: '/var/run/q...

• system_tests_network

  VmNetworking_debian-11/test_020_simple_proxyvm_nm (1/5 times with errors)

  • job 37537 AssertionError: 1 != 0 : nm-applet window not found
  VmNetworking_whonix-gw-16/test_050_spoof_ip (1/5 times with errors)

  • job 37925 None

• system_tests_pvgrub_salt_storage

  TC_40_PVGrub_debian-11/test_000_standalone_vm (2/5 times with errors)

  • job 36944 qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...
  • job 37928 qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...
  TC_40_PVGrub_debian-11/test_010_template_based_vm (4/5 times with errors)

  • job 36483 qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...
  • job 36944 qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...
  • job 37540 qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...
  • job 37928 qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...

• system_tests_splitgpg

  TC_10_Thunderbird_debian-11/test_010_send_receive_inline_signed_only (1/5 times with errors)

  • job 37296 dogtail.tree.SearchError: descendent of [application | Thunderbird]...

• system_tests_extra

  TC_00_PDFConverter_debian-11/test_001_two_pages (1/5 times with errors)

  • job 37287 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...

• system_tests_qrexec

  TC_00_Qrexec_debian-11/test_050_qrexec_simple_eof (1/5 times with errors)

  • job 37915 AssertionError: Timeout, probably EOF wasn't transferred to the VM ...
  TC_00_Qrexec_debian-11/test_070_qrexec_vm_simultaneous_write (1/5 times with errors)

  • job 37527 AssertionError: Timeout, probably deadlock

• system_tests_network_ipv6

  VmIPv6Networking_debian-11/test_020_simple_proxyvm_nm (2/5 times with errors)

  • job 36481 AssertionError: 1 != 0 : nm-applet window not found
  • job 37538 AssertionError: 1 != 0 : nm-applet window not found
  VmIPv6Networking_whonix-ws-16/test_020_simple_proxyvm_nm (1/5 times with errors)

  • job 36481 None
  VmIPv6Networking_debian-11/test_520_ipv6_simple_proxyvm_nm (1/5 times with errors)

  • job 37926 AssertionError: 1 != 0 : nm-applet window not found

• system_tests_dispvm

  TC_20_DispVM_debian-11/test_100_open_in_dispvm (2/5 times with errors)

  • job 37312 AssertionError: './open-file test.txt' failed with ./open-file test...
  • job 37521 AssertionError: './open-file test.txt' failed with ./open-file test...
  TC_20_DispVM_whonix-ws-16/test_100_open_in_dispvm (4/5 times with errors)

  • job 36464 AssertionError: libvirt event impl drain timeout
  • job 37312 AssertionError: libvirt event impl drain timeout
  • job 37521 AssertionError: './open-file test.txt' failed with ./open-file test...
  • job 37909 AssertionError: libvirt event impl drain timeout

• system_tests_basic_vm_qrexec_gui_btrfs

  TC_30_Gui_daemon/test_000_clipboard (1/5 times with errors)

  • job 37524 self.assertEqual(clipboard_content, ... AssertionError: '' != 'test23'

• system_tests_basic_vm_qrexec_gui_ext4

  TC_30_Gui_daemon/test_000_clipboard (2/5 times with errors)

  • job 37280 self.assertEqual(clipboard_content, ... AssertionError: '' != 'test22'
  • job 37913 self.assertEqual(clipboard_content, ... AssertionError: '' != 'test22'
  TC_00_AppVM_whonix-gw-16-pool/test_000_start_shutdown (1/5 times with errors)

  • job 37552 qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...
  TC_00_AppVM_whonix-gw-16-pool/test_010_run_xterm (1/5 times with errors)

  • job 37552 OSError: Volume /var/lib/qubes-pool/appvms/test-inst-vm1/private.im...

• system_tests_basic_vm_qrexec_gui_xfs

  TC_30_Gui_daemon/test_000_clipboard (1/5 times with errors)

  • job 36469 self.assertEqual(clipboard_content, ... AssertionError: '' != 'test23'
  TC_00_AppVM_debian-11-pool/test_221_audio_rec_muted (1/5 times with errors)

  • job 37526 subprocess.CalledProcessError: Command '['sudo', '-E', '-u', 'user'...

• system_tests_network_updates

  TC_10_QvmTemplate_debian-11/test_010_template_install (1/5 times with errors)

  • job 37927 AssertionError: libvirt event impl drain timeout
  TC_10_QvmTemplate_whonix-gw-16/test_010_template_install (1/5 times with errors)

  • job 36943 AssertionError: libvirt event impl drain timeout