dom0-update: do not send --downloadonly option to the updatevm #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updatevm already downloads packages only (either using --downloadonly option internally, or using yumdownloader). The option from the user matters for the dnf call in dom0 only. Especially, sending --downloadonly breaks downloading updates via debian-10, which uses yumdownloader, as it doesn't have --downloadonly option. This is mostly relevant for R4.0 -> R4.1 upgrade (and maybe some future too?), as the process uses --downloadonly option internally. QubesOS/qubes-issues#5685
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/25622#dependencies Failed tests
New failuresCompared to: https://openqa.qubes-os.org/tests/17576#dependencies
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/17576#dependencies
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updatevm already downloads packages only (either using
--downloadonly option internally, or using yumdownloader). The option
from the user matters for the dnf call in dom0 only.
Especially, sending --downloadonly breaks downloading updates via
debian-10, which uses yumdownloader, as it doesn't have --downloadonly
option.
This is mostly relevant for R4.0 -> R4.1 upgrade (and maybe some future
too?), as the process uses --downloadonly option internally.
QubesOS/qubes-issues#5685