Fix creating template.rpm symlink #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create symlink using absolute path to the template rpm package. This is important because relative path given to qvm-template should be considered in relation to the current working directory, not template.rpm symlink location. This fixes calling `qvm-template install` using relative path to the package. Fixes QubesOS/qubes-issues#9246
marmarek
force-pushed
the
template-symlink
branch
from
76c924e to
7f8da8a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 74.43% 74.44%
=======================================
Files 51 51
Lines 7921 7923 +2
=======================================
+ Hits 5896 5898 +2
Misses 2025 2025 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024052318-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024051522-4.2&flavor=update
Failed tests21 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/99767#dependencies 2 fixed
Unstable tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create symlink using absolute path to the template rpm package.
This is important because relative path given to qvm-template should be
considered in relation to the current working directory, not
template.rpm symlink location.
This fixes calling
qvm-template installusing relative path to thepackage.
Fixes QubesOS/qubes-issues#9246