Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated operators to print with hat #79

Closed
wants to merge 6 commits into from
Closed

Updated operators to print with hat #79

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a0a7f9
Updated operators to print with hat
rbaliarizona Aug 13, 2024
3e00446
updated hat to print at the center character of an operator
rbaliarizona Aug 14, 2024
953e3eb
removed accidentally added dependency
rbaliarizona Aug 14, 2024
499236f
Merge branch 'main' into rbali_print
rbaliarizona Aug 14, 2024
3005796
Merge branch 'main' into rbali_print
Krastanov Nov 14, 2024
955a95f
add hat only to the first character
Krastanov Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# News

## v0.4.3 - 2024-08-13

- Operators now print with hat

## v0.4.2 - 2024-08-11

- `@withmetadata` now supports inline docstrings for struct fields
Expand Down
2 changes: 1 addition & 1 deletion src/QSymbolicsBase/literal_objects.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ basis(x::SymQ) = x.basis

Base.show(io::IO, x::SKet) = print(io, "|$(symbollabel(x))⟩")
Base.show(io::IO, x::SBra) = print(io, "⟨$(symbollabel(x))|")
Base.show(io::IO, x::Union{SOperator,SHermitianOperator,SUnitaryOperator,SHermitianUnitaryOperator,SSuperOperator}) = print(io, "$(symbollabel(x))")
Base.show(io::IO, x::Union{SOperator,SHermitianOperator,SUnitaryOperator,SHermitianUnitaryOperator,SSuperOperator}) = print(io, "$(symbollabel(x))̂")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two points:

  • we probably should insert the hat on the first letter (not all operators are a single symbol)

  • let's remove SSuperOperator from this list for the moment, as it has a bit more complicated printing

Base.show(io::IO, x::SymQObj) = print(io, symbollabel(x)) # fallback that probably is not great

struct SZero{T<:QObj} <: Symbolic{T} end
Expand Down
Loading