Clean up metadata addition to struct definitions #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 73.88% 73.70% -0.18%
==========================================
Files 18 18
Lines 804 791 -13
==========================================
- Hits 594 583 -11
+ Misses 210 208 -2 ☔ View full report in Codecov by Sentry. |
|
the tests are not failing and this is pretty darn fundamental to the library, so it must be good to merge. Feel free to merge as you find appropriate |
Krastanov
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originates from discussion in #62. The
withmetadatamacro is designed to add a metadata dict to certain struct definitions. Currently, it is unnecessarily messy and hard to read because it doesn't make use of any pattern-matching packages. This PR makes use of tools from MacroTools.jl to clean up the macro.