Add qexpand functionality and cleanup scalings #59
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| [default.extend-words] | ||
| ket = "ket" | ||
| BA = "BA" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| ## | ||
| # Linear algebra operations on quantum objects. | ||
| ## | ||
|
|
||
| """Projector for a given ket | ||
|
|
||
| ```jldoctest | ||
| julia> SProjector(X1⊗X2) | ||
| 𝐏[|X₁⟩|X₂⟩] | ||
|
|
||
| julia> express(SProjector(X2)) | ||
| Operator(dim=2x2) | ||
| basis: Spin(1/2) | ||
| 0.5+0.0im -0.5-0.0im | ||
| -0.5+0.0im 0.5+0.0im | ||
| ```""" | ||
| @withmetadata struct SProjector <: Symbolic{AbstractOperator} | ||
| ket::Symbolic{AbstractKet} # TODO parameterize | ||
| end | ||
| isexpr(::SProjector) = true | ||
| iscall(::SProjector) = true | ||
| arguments(x::SProjector) = [x.ket] | ||
| operation(x::SProjector) = projector | ||
| head(x::SProjector) = :projector | ||
| children(x::SProjector) = [:projector,x.ket] | ||
| projector(x::Symbolic{AbstractKet}) = SProjector(x) | ||
| projector(x::SZeroKet) = SZeroOperator() | ||
| basis(x::SProjector) = basis(x.ket) | ||
| function Base.show(io::IO, x::SProjector) | ||
| print(io,"𝐏[") | ||
| print(io,x.ket) | ||
| print(io,"]") | ||
| end | ||
|
|
||
| """Dagger, i.e., adjoint of quantum objects (kets, bras, operators) | ||
|
|
||
| ```jldoctest | ||
| julia> @ket a; @op A; | ||
|
|
||
| julia> dagger(2*im*A*a) | ||
| (0 - 2im)|a⟩†A† | ||
|
|
||
| julia> @op B; | ||
|
|
||
| julia> dagger(A*B) | ||
| B†A† | ||
|
|
||
| julia> ℋ = SHermitianOperator(:ℋ); U = SUnitaryOperator(:U); | ||
|
|
||
| julia> dagger(ℋ) | ||
| ℋ | ||
|
|
||
| julia> dagger(U) | ||
| U⁻¹ | ||
| ``` | ||
| """ | ||
| @withmetadata struct SDagger{T<:QObj} <: Symbolic{T} | ||
| obj | ||
| end | ||
| isexpr(::SDagger) = true | ||
| iscall(::SDagger) = true | ||
| arguments(x::SDagger) = [x.obj] | ||
| operation(x::SDagger) = dagger | ||
| head(x::SDagger) = :dagger | ||
| children(x::SDagger) = [:dagger, x.obj] | ||
| dagger(x::Symbolic{AbstractBra}) = SDagger{AbstractKet}(x) | ||
| dagger(x::Symbolic{AbstractKet}) = SDagger{AbstractBra}(x) | ||
| dagger(x::Symbolic{AbstractOperator}) = SDagger{AbstractOperator}(x) | ||
| dagger(x::SScaledKet) = SScaledBra(conj(x.coeff), dagger(x.obj)) | ||
| dagger(x::SAdd) = (+)((dagger(i) for i in arguments(x))...) | ||
| dagger(x::SScaledBra) = SScaledKet(conj(x.coeff), dagger(x.obj)) | ||
| dagger(x::SZeroOperator) = x | ||
| dagger(x::SHermitianOperator) = x | ||
| dagger(x::SHermitianUnitaryOperator) = x | ||
| dagger(x::SUnitaryOperator) = inv(x) | ||
| dagger(x::STensorBra) = STensorKet(collect(dagger(i) for i in x.terms)) | ||
| dagger(x::STensorKet) = STensorBra(collect(dagger(i) for i in x.terms)) | ||
| dagger(x::STensorOperator) = STensorOperator(collect(dagger(i) for i in x.terms)) | ||
| dagger(x::SScaledOperator) = SScaledOperator(conj(x.coeff), dagger(x.obj)) | ||
| dagger(x::SApplyKet) = dagger(x.ket)*dagger(x.op) | ||
| dagger(x::SApplyBra) = dagger(x.op)*dagger(x.bra) | ||
| dagger(x::SMulOperator) = SMulOperator(collect(dagger(i) for i in reverse(x.terms))) | ||
| dagger(x::SBraKet) = SBraKet(dagger(x.ket), dagger(x.bra)) | ||
| dagger(x::SOuterKetBra) = SOuterKetBra(dagger(x.bra), dagger(x.ket)) | ||
| dagger(x::SDagger) = x.obj | ||
| basis(x::SDagger) = basis(x.obj) | ||
| function Base.show(io::IO, x::SDagger) | ||
| print(io,x.obj) | ||
| print(io,"†") | ||
| end | ||
|
|
||
| """Inverse Operator | ||
|
|
||
| ```jldoctest | ||
| julia> @op A; | ||
|
|
||
| julia> inv(A) | ||
| A⁻¹ | ||
|
|
||
| julia> inv(A)*A | ||
| 𝕀 | ||
| ``` | ||
| """ | ||
| @withmetadata struct SInvOperator <: Symbolic{AbstractOperator} | ||
| op::Symbolic{AbstractOperator} | ||
| end | ||
| isexpr(::SInvOperator) = true | ||
| iscall(::SInvOperator) = true | ||
| arguments(x::SInvOperator) = [x.op] | ||
| operation(x::SInvOperator) = inv | ||
| head(x::SInvOperator) = :inv | ||
| children(x::SInvOperator) = [:inv, x.op] | ||
| basis(x::SInvOperator) = basis(x.op) | ||
| Base.show(io::IO, x::SInvOperator) = print(io, "$(x.op)⁻¹") | ||
| Base.:(*)(invop::SInvOperator, op::SOperator) = isequal(invop.op, op) ? IdentityOp(basis(op)) : SMulOperator(invop, op) | ||
| Base.:(*)(op::SOperator, invop::SInvOperator) = isequal(op, invop.op) ? IdentityOp(basis(op)) : SMulOperator(op, invop) | ||
| inv(x::Symbolic{AbstractOperator}) = SInvOperator(x) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit suspicious. There is no one-to-one correspondence between the dictionary, set, and list forms anymore. I think what you want is actually
countmap_flattenas seen hereQuantumSymbolics.jl/src/QSymbolicsBase/basic_ops_homogeneous.jl
Line 97 in 079ea5e
Given that there is already flattening done in the
+operation, I think we can just not do any flattening here. Just take the dictionary and do not worry about processing it. Any normal use ofSAdd, usually through the use of+will already take care of flattening. This is a fairly general statement: fancy processing should be done in calls to+and*, not in constructors.Also, something I did not notice previously, the variable names are misleading here. It should be
(obj, coef) in dnot(coef, obj) in d.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this particular case, unlike the other constructors, we probably still want to keep the inner constructor that makes sure to create the set and vector.