doctest and piracy fixes

QuantumSavory · Jul 2, 2024 · e41dc7e · e41dc7e
1 parent 057a837
commit e41dc7e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 13 deletions.
diff --git a/src/QSymbolicsBase/QSymbolicsBase.jl b/src/QSymbolicsBase/QSymbolicsBase.jl
@@ -11,7 +11,7 @@ import LinearAlgebra: eigvecs,ishermitian,inv
 import QuantumInterface:
     apply!,
     tensor, ⊗,
-    basis,Basis,SpinBasis,FockBasis,
+    basis,Basis,SpinBasis,FockBasis,CompositeBasis,
     nqubits,
     projector,dagger,tr,ptrace,
     AbstractBra,AbstractKet,AbstractOperator,AbstractSuperOperator

diff --git a/src/QSymbolicsBase/basic_ops_homogeneous.jl b/src/QSymbolicsBase/basic_ops_homogeneous.jl
@@ -201,9 +201,6 @@ julia> @op A; @op B;
 julia> commutator(A, B)
 [A,B]
 
-julia> expand(commutator(A, B))
-(-1BA+AB)
-
 julia> commutator(A, A)
 𝟎
 ```
@@ -235,9 +232,6 @@ julia> @op A; @op B;
 
 julia> anticommutator(A, B)
 {A,B}
-
-julia> expand(anticommutator(A, B))
-(AB+BA)
 ```
 """
 @withmetadata struct SAnticommutator <: Symbolic{AbstractOperator}

diff --git a/src/QSymbolicsBase/linalg.jl b/src/QSymbolicsBase/linalg.jl
@@ -129,10 +129,15 @@ Base.isequal(x::STrace, y::STrace) = isequal(x.op, y.op)
 """Partial trace over system i of a composite quantum system
 
 ```jldoctest
-julia> @op A; @op B;
+julia> @op 𝒪 SpinBasis(1//2) ⊗ SpinBasis(1//2);
+
+julia> op = ptrace(𝒪, 1)
+tr1(𝒪)
 
-julia> ptrace(A, 1)
-tr1(A)
+julia> QuantumSymbolics.basis(op)
+Spin(1/2)
+
+julia> @op A; @op B;
 
 julia> ptrace(A⊗B, 1)
 (tr(A))B
@@ -175,7 +180,7 @@ function basis(x::SPartialTrace)
 end
 Base.show(io::IO, x::SPartialTrace) = print(io, "tr$(x.sys)($(x.obj))")
 function ptrace(x::Symbolic{AbstractOperator}, s) 
-    if isa(basis(x), QuantumInterface.CompositeBasis)
+    if isa(basis(x), CompositeBasis)
         SPartialTrace(x, s)
     else
         throw(ArgumentError("cannot take partial trace of a single quantum system"))
@@ -184,7 +189,7 @@ end
 function ptrace(x::STensorOperator, s)
     terms = arguments(x)
     newterms = []
-    if isa(basis(terms[s]), QuantumInterface.CompositeBasis)
+    if isa(basis(terms[s]), CompositeBasis)
         SPartial(x, s)
     else 
         sys_op = terms[s]

diff --git a/src/QSymbolicsBase/literal_objects.jl b/src/QSymbolicsBase/literal_objects.jl
@@ -106,4 +106,4 @@ symbollabel(x::SZero) =  "𝟎"
 basis(x::SZero) = nothing
 
 Base.show(io::IO, x::SZero) = print(io, symbollabel(x))
-Base.iszero(x::Union{SymQObj, Symbolic{Number}, Symbolic{Complex}}) = isa(x, SZero)
+Base.iszero(x::SymQObj) = isa(x, SZero)