-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for QuantumSymbolics to 0.4, (keep existing compat) #144
CompatHelper: bump compat for QuantumSymbolics to 0.4, (keep existing compat) #144
Conversation
d561394
to
b66f42b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 69.26% 72.94% +3.68%
==========================================
Files 39 39
Lines 1692 1693 +1
==========================================
+ Hits 1172 1235 +63
+ Misses 520 458 -62 ☔ View full report in Codecov by Sentry. |
@apkille |
Yes, I'll take a look. |
@Krastanov It's because descriptive strings are included above each field of your struct definitions, e.g.,
@capture command captures a string as a field. Here's two different ways we could fix this: we could use MacroTools.isexpr(expr, String, :string) to filter out these strings when we are decorating the struct definition, or change these descriptive strings into single-line comments next to the fields.
|
The first option would look something like this:
Here,
|
@Krastanov submitted a PR to QSymbolics.jl that implements the first option. If you don't agree with those changes, that's OK! |
This pull request changes the compat entry for the
QuantumSymbolics
package from0.3
to0.3, 0.4
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.