-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken doctests and typos #438
base: master
Are you sure you want to change the base?
Conversation
These fixes are much appreciated! But I am also a bit confused: any idea how come these problems were not detected by the test runner? |
The test runner didn't detect these errors because it did not construct the code to check the parameters: the parameters (108,12) were given to it on the platter. QuantumClifford.jl/ext/QuantumCliffordHeckeExt/lifted_product.jl Lines 254 to 255 in 7b444e9
To the test runner, this was correct because it was the expected result. It didn't calculate the parameters to verify it, as the calculation step - the code construction => to calculate the parameters was missing. This was a silly error. My bad. |
In the first doctest fix, the group algebra, QuantumClifford.jl/ext/QuantumCliffordHeckeExt/lifted_product.jl Lines 218 to 230 in 7b444e9
|
That does not seem to be the correct explanation. It seems these doctests, because they were in an extension, were actually never executed. Hopefully the last commit I pushed fixes that. Thanks for flagging this issue! That would have been unresolved and untested for a long time otherwise. Good catch! |
This PR implements minor fixes in doctests.
Edit: