Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noncliff: scaffolding for projectrand! for GeneralizedStabilizer #420

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Nov 4, 2024

This PR sets up the scaffolding for projectrand! in GeneralizedStabilizer, inspired by comments in #355. The goal is to provide clear, well-documented code for readers unfamiliar with the original paper.

I think the work for projectrand! can be divided into the following portions. Work for define _proj and basic tests is underway in #355, and the #418 is being investigated. Segmenting the work in this modular way facilitates future additions and modifications, while also preventing confusion by isolating distinct components.

graph TD
    %% Define subgraph for scaffolding
    subgraph ScaffoldingBranch [ ]
        direction TB
        B[Scaffolding] --> B1[convert expectation to prob <br> randomly choose projection]
    end

    A[projectrand!] --> B
    A --> C[Nitty Gritty]
    C --> C1[define_proj]

    A --> D[Unrelated Errors, <br> Issue #418 ]
    D --> D1[Resolve projection inconsistencies for multi-qubit Stabilizer/MixedDestabilizer ]
   
    A --> E[Testing for Consistency]
    E --> E1[multi-qubit stabilizer <br>multi-qubit pauli <br>non-stabilizer]
Loading

@Fe-r-oz Fe-r-oz force-pushed the fa/scaffoldingprojectrand! branch 4 times, most recently from a5feebd to 3cd7105 Compare November 4, 2024 19:19
@Fe-r-oz Fe-r-oz force-pushed the fa/scaffoldingprojectrand! branch from 3cd7105 to a198877 Compare November 4, 2024 19:36
@Krastanov
Copy link
Member

this seems like reasonable setup. Do you want this merged first or do you prefer to fill out the scaffolding?

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Nov 5, 2024

I think let's merge this first so that the define_proj can be reviewed separately. Much Appreciated!

…hey are not always viewed together -- here `sm` would have been unknown to the reader
@Krastanov Krastanov merged commit e4a6479 into QuantumSavory:nonclif Nov 5, 2024
6 of 12 checks passed
@Fe-r-oz Fe-r-oz deleted the fa/scaffoldingprojectrand! branch November 7, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants