-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hecke's Small Groups (small_group(l, Id)
) without any extra relations for single cyclic groups
#406
Open
Fe-r-oz
wants to merge
5
commits into
QuantumSavory:master
Choose a base branch
from
Fe-r-oz:fa/Heckesmallgroup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fe-r-oz
changed the title
Introducing Group Presentations via Hecke's Small Groups
Introducing Group Presentations via Hecke's Small Groups for single cyclic groups
Oct 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 83.00% 82.95% -0.05%
==========================================
Files 71 71
Lines 4565 4565
==========================================
- Hits 3789 3787 -2
- Misses 776 778 +2 ☔ View full report in Codecov by Sentry. |
Fe-r-oz
changed the title
Introducing Group Presentations via Hecke's Small Groups for single cyclic groups
using Hecke's Small Groups for single cyclic groups
Oct 27, 2024
Fe-r-oz
changed the title
using Hecke's Small Groups for single cyclic groups
using Hecke's Small Groups without any extra relations for single cyclic groups
Oct 27, 2024
Fe-r-oz
force-pushed
the
fa/Heckesmallgroup
branch
from
October 28, 2024 11:40
f95a290
to
cba74cb
Compare
Fe-r-oz
changed the title
using Hecke's Small Groups without any extra relations for single cyclic groups
using Hecke's Small Groups (Nov 27, 2024
small_group(l, Id)
) without any extra relations for single cyclic groups
Fe-r-oz
changed the title
using Hecke's Small Groups (
introducing Hecke's Small Groups (Nov 27, 2024
small_group(l, Id)
) without any extra relations for single cyclic groups small_group(l, Id)
) without any extra relations for single cyclic groups
Fe-r-oz
changed the title
introducing Hecke's Small Groups (
Hecke's Small Groups (Nov 27, 2024
small_group(l, Id)
) without any extra relations for single cyclic groups small_group(l, Id)
) without any extra relations for single cyclic groups
Please help review this PR, Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Hecke.small_group for 'abelian' 2BGA codes for single cyclic groups. Hecke.small groups are limited, they can only be used single cyclic groups.