-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coprime Bivariate Bicycle code via Hecke's Group Algebra #378
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3d5369b
CoPrime Bivariate Bicycle codes via Lifted Product Construction
Fe-r-oz e89bca6
Merge branch 'QuantumSavory:master' into coprime
Fe-r-oz 7cbe4f7
significant simplification
Fe-r-oz fe069b0
Reproduce Table 2
Fe-r-oz 8860954
Merge branch 'QuantumSavory:master' into coprime
Fe-r-oz 6f1967b
Merge branch 'master' into coprime
Fe-r-oz ec88899
add wonderful codereview suggestions
Fe-r-oz ea7edc2
add coprimeBB to test_ecc_base to test its properties
Fe-r-oz 640a198
Merge branch 'master' into coprime
Krastanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
@testitem "ECC coprime Bivaraite Bicycle" begin | ||
using Nemo | ||
using Nemo: gcd | ||
using Hecke | ||
using Hecke: group_algebra, GF, abelian_group, gens | ||
using QuantumClifford.ECC: two_block_group_algebra_codes, code_k, code_n | ||
|
||
@testset "Reproduce Table 2 wang2024coprime" begin | ||
# [[30,4,6]] | ||
l=3; m=5; | ||
GA = group_algebra(GF(2), abelian_group([l*m])) | ||
𝜋 = gens(GA)[1] | ||
A = 1 + 𝜋 + 𝜋^2 | ||
B = 𝜋 + 𝜋^3 + 𝜋^8 | ||
c = two_block_group_algebra_codes(A, B) | ||
@test gcd([l,m]) == 1 | ||
@test code_n(c) == 30 && code_k(c) == 4 | ||
|
||
# [[42,6,6]] | ||
l=3; m=7; | ||
GA = group_algebra(GF(2), abelian_group([l*m])) | ||
𝜋 = gens(GA)[1] | ||
A = 1 + 𝜋^2 + 𝜋^3 | ||
B = 𝜋 + 𝜋^3 + 𝜋^11 | ||
c = two_block_group_algebra_codes(A, B) | ||
@test gcd([l,m]) == 1 | ||
@test code_n(c) == 42 && code_k(c) == 6 | ||
|
||
# [[70,6,8]] | ||
l=5; m=7; | ||
GA = group_algebra(GF(2), abelian_group([l*m])) | ||
𝜋 = gens(GA)[1] | ||
A = 1 + 𝜋 + 𝜋^5; | ||
B = 1 + 𝜋 + 𝜋^12; | ||
c = two_block_group_algebra_codes(A, B) | ||
@test gcd([l,m]) == 1 | ||
@test code_n(c) == 70 && code_k(c) == 6 | ||
|
||
# [[108,12,6]] | ||
l=2; m=27; | ||
GA = group_algebra(GF(2), abelian_group([l*m])) | ||
𝜋 = gens(GA)[1] | ||
A = 𝜋^2 + 𝜋^5 + 𝜋^44 | ||
B = 𝜋^8 + 𝜋^14 + 𝜋^47 | ||
c = two_block_group_algebra_codes(A, B) | ||
@test gcd([l,m]) == 1 | ||
@test code_n(c) == 108 && code_k(c) == 12 | ||
|
||
# [[126,12,10]] | ||
l=7; m=9 | ||
GA = group_algebra(GF(2), abelian_group([l*m])) | ||
𝜋 = gens(GA)[1] | ||
A = 1 + 𝜋 + 𝜋^58 | ||
B = 𝜋^3 + 𝜋^16 + 𝜋^44 | ||
c = two_block_group_algebra_codes(A, B) | ||
@test gcd([l,m]) == 1 | ||
@test code_n(c) == 126 && code_k(c) == 12 | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very useful set of tests! It should probably directly use
two_block_group_algebra_code
instead of the more round-about construction with LPCode