-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inv
implementation for SingleQubitOperator
#314
Conversation
Locally the tests passes: I hope it will pass here as well.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of notes
To make it easier for reviewers, could you also either mark unfinished pull requests as "draft"? (you are mentioning that you will be adding more to this one).
It is also a good idea to generally make small pull requests that do only one thing, as I would be much quicker to review such pull requests. So you can for instance just deal with single qubit gates in this pull request and submit the multi-qubit gate later. That makes reviewing and merging drastically easier.
Thanks! Generally, do not worry about reporting stuff like that. I will anyway wait for the CI to run, so no need to investigate things unless there is a problem. |
Thank you for these notes! |
inv
implementation for all subtypes of AbstractCliffordOperator
inv
implementation for all subtypes of AbstractSingleOperator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 82.97% 82.96% -0.01%
==========================================
Files 61 61
Lines 4023 4033 +10
==========================================
+ Hits 3338 3346 +8
- Misses 685 687 +2 ☔ View full report in Codecov by Sentry. |
inv
implementation for all subtypes of AbstractSingleOperator
inv
implementation for SingleQubitOperator
Thanks for your comments. Indeed, they helped to polish the PR. I hope this is alright now! |
Thanks for the contribution! |
Thanks for the feedback! |
--------- Co-authored-by: Stefan Krastanov <[email protected]>
Functionality that we want
I will add the twoqubit invs today as well. Hope you find this plausible!