-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add random Clifford circuit codes #298
Conversation
@Krastanov, please help review this PR; thanks! (The failed CI check is related to #245 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! You mentioned how it does not work well with many decoders. How does it perform with belief propagation and OSD decoders?
Actually, However, we need random circuit codes with more than 10 qubits, e.g., 20 qubits, to ensure the randomly generated codes have a distance larger than 0. This will make
BP and BP-OSD in
|
…ms.jl; improve documents
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
==========================================
+ Coverage 82.85% 82.97% +0.12%
==========================================
Files 60 61 +1
Lines 3971 4023 +52
==========================================
+ Hits 3290 3338 +48
- Misses 681 685 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more minor stylistic changes
What is the current status? |
I did not fully comprehend some of your previous review comments and was waiting for your further replies on them. I will get this PR updated quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but there are a few stylistic changes that I would like, to make it a bit more in the style of the rest of the library
Wonderful! Thanks for the addition |
--------- Co-authored-by: Stefan Krastanov <[email protected]>
Add implementations of random Clifford circuit codes, whose connectivity can be all-to-all or brickwork in some dimensions.
Some notes:
AbstractOperations[]
of sparse gates for the generated circuit, which should be more efficient and allow visualization.ecc_decoder_all_setups
in this PR. The reason is that to ensure a good code parameter, the code has to contain more than 10 qubits, which exceeds the size thatTableDecoder
can efficiently handle. Random circuit codes are not CSS and are currently unsupported byPyMatchingDecoder
.