adding iscss for issue #222

[Fe-r-oz]

Given the stabilizer has the knowledge, the isscss function is implemented.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (3bb4653) to head (c674273).

❗ Current head c674273 differs from pull request most recent head b03ed6a. Consider uploading reports for the commit b03ed6a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   82.60%   88.02%   +5.41%     
==========================================
  Files          56       42      -14     
  Lines        3749     3324     -425     
==========================================
- Hits         3097     2926     -171     
+ Misses        652      398     -254     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Krastanov]

Thank for starting this! Please read a bit more on multiple dispatch and methods in julia and restructure appropriately (see related comments)

https://docs.julialang.org/en/v1/manual/methods/

[Krastanov]

And this probably needs some tests. E.g. for each code check what iscss says and then check whether their parity check matrix is indeed in CSS form. The check would be expensive, it will have to go through the entire tableau of a specific code instance, but it will be happening only when running the test suite.

[Fe-r-oz]

And this probably needs some tests. E.g. for each code check what iscss says and then check whether their parity check matrix is indeed in CSS form. The check would be expensive, it will have to go through the entire tableau of a specific code instance, but it will be happening only when running the test suite.

I thought this was not needed because the stabilizer has the knowledge as you said. Only, tests are to be remaining
Please have a look at modifications. Only test definition is remaining.

so, now I need to use an algorithm that check whether H matrix is in CSS form? Can the stabilizer knowledge can be used here or it's an expensive method, I need to look for a general algorithm in literature?

[Krastanov]

I thought this was not needed because the stabilizer has the knowledge as you said. Only, tests are to be remaining.

The point of tests is to check whether such assumptions or internal constants are correct. It is not something that runs when the user is using the library, rather it is for the developers to check whether they have made an error (e.g. like setting iscss(::SomeCode) = true when it should not be).

[Krastanov]

I need to look for a general algorithm in literature?

It is a simple check, not something that you need to look up in the literature. For each row of a parity check tableau check whether it contains a mix of X and Z. As long as they do not, it is a CSS code.

[Krastanov]

Thank you! This is getting pretty close. I left a few comments.

[Krastanov]

I also see you are making a ton of small commits just as you are working through things.

It helps to do the following:

• try to make commits that are somewhat selfcontained and tell a clear story of how the work is evolving
• use the --amend flag to just add to the last commit instead of creating a new commit, if they are not logically separated
• aim to push in one big batch, not after each commit, because each time you push, fairly expensive automated testing is being run on your code. No need to test code you know is unfinished. Generally, run the tests locally (with the ]test QuantumClifford command) before pushing, to make sure the tests pass for you first

[Krastanov]

do not worry about the buildkite failure -- it will work again after a few new version registrations get propagated through the ecosystem

[Fe-r-oz]

I also see you are making a ton of small commits just as you are working through things.

Thanks for your comments. I will keep this in mind All the requested changes are done.

[Krastanov]

There are two rather minor issues, but they are also issues that are simply due to inattentiveness, not to some big conceptual problem. Please make sure you reread your code closely before submitting for reviews -- It is important to build up the habit to detect this type of minor issues on your own.

[Fe-r-oz]

There are two rather minor issues

Minor issues are dealth with

[Krastanov]

I made a minor rephrasing in the changelog. I will wait for the tests and then merge. Thank you, having this done is very helpful!

[Krastanov]

Be more careful with title and references. This closes issue 222, not issue 212. A bit too late to change the commit message now, so we can just close it manually.

[Fe-r-oz]

I made a minor rephrasing in the changelog. I will wait for the tests and then merge. Thank you, having this done is very helpful!

Thank you as well!