code review suggestions

QuantumSavory · Oct 25, 2024 · 11a0064 · 11a0064
1 parent 429f21c
commit 11a0064
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/ext/QuantumCliffordHeckeExt/util.jl b/ext/QuantumCliffordHeckeExt/util.jl
@@ -8,7 +8,7 @@ condition.
 """
 function check_repr_commutation_relation(GA::GroupAlgebra)
     a, b = rand(GA), rand(GA)
-    # Check commutation relation: L(a) R(b) == R(b) L(a)
+    # Check commutation relation: L(a)R(b) = R(b)L(a)
     L_a = representation_matrix(a)
     R_a = representation_matrix(b, :right)
     return L_a * R_a == R_a * L_a

diff --git a/src/ecc/ECC.jl b/src/ecc/ECC.jl
@@ -15,7 +15,7 @@ abstract type AbstractECC end
 
 export parity_checks, parity_checks_x, parity_checks_z, iscss,
     code_n, code_s, code_k, rate, distance,
-    isdegenerate, faults_matrix, check_repr_commutation_relation,
+    isdegenerate, faults_matrix,
     naive_syndrome_circuit, shor_syndrome_circuit, naive_encoding_circuit,
     RepCode, LiftedCode,
     CSS,

diff --git a/test/test_ecc_base.jl b/test/test_ecc_base.jl
@@ -1,6 +1,7 @@
 using Test
 using QuantumClifford
 using QuantumClifford.ECC
+using QuantumClifford.ECC:check_repr_commutation_relation
 using InteractiveUtils
 
 import Nemo: GF
@@ -46,7 +47,7 @@ other_lifted_product_codes = []
 # [[882, 24, d≤24]] code from (B1) in Appendix B of [panteleev2021degenerate](@cite)
 l = 63
 GA = group_algebra(GF(2), abelian_group(l))
-@test check_repr_commutation_relation(GA) == true
+@test check_repr_commutation_relation(GA)
 A = zeros(GA, 7, 7)
 x = gens(GA)[]
 A[LinearAlgebra.diagind(A)] .= x^27