Add missing operators for Vector2<T> #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this looks good! Would you mind adding some unit tests for this please? The Clippy failures look like issues with |
|
Clippy is now fixed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that there are a couple of very common operator implementations missing for Vector2.
Namely,
Neg(-vec) and left scalarMul(scalar * vec). The latter is interesting, because it seems to be just a Rust limitation, as it would require implementing a foreign trait for a completely foreign type.That said, putting a scalar on the left side of the multiplication is so common (standard in textbooks) that I implemented that for the concrete Vector2s in
dimen.rs.Additionally, I included a rotate_180_degrees() method to Vector2 that simply negates it, for completeness sake.