Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update decomposition #15

Merged
merged 11 commits into from
Jun 17, 2024
Merged

Update decomposition #15

merged 11 commits into from
Jun 17, 2024

Conversation

NicoRenaud
Copy link

Added possibility for matrices to update their decomposition
By default it does a reinit

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9518930781

Details

  • 12 of 25 (48.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 82.081%
Changes Missing Coverage Covered Lines Changed/Added Lines %
vqls_prototype/solver/vqls.py 3 5 60.0%
vqls_prototype/matrix_decomposition/matrix_decomposition.py 9 20 45.0%
Totals Coverage Status
Change from base Build 8849473643: -0.5%
Covered Lines: 1333
Relevant Lines: 1624
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9547169116

Details

  • 13 of 26 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 82.092%
Changes Missing Coverage Covered Lines Changed/Added Lines %
vqls_prototype/solver/vqls.py 4 6 66.67%
vqls_prototype/matrix_decomposition/matrix_decomposition.py 9 20 45.0%
Totals Coverage Status
Change from base Build 8849473643: -0.5%
Covered Lines: 1334
Relevant Lines: 1625
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9547966870

Details

  • 13 of 26 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 82.092%
Changes Missing Coverage Covered Lines Changed/Added Lines %
vqls_prototype/solver/vqls.py 4 6 66.67%
vqls_prototype/matrix_decomposition/matrix_decomposition.py 9 20 45.0%
Totals Coverage Status
Change from base Build 8849473643: -0.5%
Covered Lines: 1334
Relevant Lines: 1625
💛 - Coveralls

NicoRenaud
NicoRenaud commented Jun 17, 2024
View reviewed changes
Copy link
Author

@NicoRenaud NicoRenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@NicoRenaud NicoRenaud merged commit 2b8b012 into main Jun 17, 2024
4 checks passed
@NicoRenaud NicoRenaud deleted the update_decomposition branch June 17, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicoRenaud @coveralls