Add tests for find_recent_logfile()

[mikeweltevrede]

Summary of Changes

Add tests for find_recent_logfile() to close #2389. Note that I also noticed that there might be some unintended functionality (see test_find_recent_logfile_only_checks_files_matching_the_extension) and added a test that is expected to fail.

Requirements

• My PR is focused on a single feature addition or bugfix.
• My PR has relevant, comprehensive unit tests.
• My PR is on a custom branch (i.e. is not named main).

Note: If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.

[buildbot-princeton]

Can one of the admins verify this patch?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (608406e) to head (591ee47).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
+ Coverage   98.80%   99.12%   +0.32%     
==========================================
  Files          84       84              
  Lines        3424     3424              
==========================================
+ Hits         3383     3394      +11     
+ Misses         41       30      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Andrew-S-Rosen]

@mikeweltevrede: Thank you very much for taking the time to write tests for this function, which in fact discovered a bug! That's why we write thorough tests, and I appreciate your attention to detail with this.

I would be happy to merge this PR once my one comment is addressed. Don't hesitate to let me know if you have any questions.

[Andrew-S-Rosen]

Fantastic, thank you @mikeweltevrede! I appreciate your help with this. This is wonderful. I am happy to merge.

[mikeweltevrede]

@Andrew-S-Rosen no problem, happy to have been able to assist :)