Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Espresso: faster tests #1819

Merged
merged 7 commits into from
Mar 2, 2024

Conversation

tomdemeyere
Copy link
Contributor

@tomdemeyere tomdemeyere commented Mar 2, 2024

Summary of Changes

As discussed in #1789 some parallelization flags can help make espresso tests faster

Checklist

  • I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
  • My PR is on a custom branch and is not named main.
  • I have added relevant, comprehensive unit tests.

Notes

  • Your PR will likely not be merged without proper and thorough tests.
  • If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
  • When your code is ready for review, ping one of the active maintainers.

Closes #1818.

@buildbot-princeton
Copy link
Collaborator

Can one of the admins verify this patch?

@tomdemeyere
Copy link
Contributor Author

It seems that OMP_NUM_THREADS=8 is indeed very inefficient, tests are down to 1m25.

I will let you deal with the details?

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (9ab2ea5) to head (4ae8f1f).

❗ Current head 4ae8f1f differs from pull request most recent head a0c7bb5. Consider uploading reports for the commit a0c7bb5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1819   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          80       80           
  Lines        3112     3112           
=======================================
  Hits         3094     3094           
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Mar 2, 2024

tests / tests-defects-phonons-espresso (pull_request) Successful in 3m

Absolutely wild!!! 🔥 I can sort out the rest.

@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) March 2, 2024 05:16
@Andrew-S-Rosen Andrew-S-Rosen disabled auto-merge March 2, 2024 05:20
@Andrew-S-Rosen Andrew-S-Rosen merged commit 6da4e7d into Quantum-Accelerators:main Mar 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Speed up the Espresso tests by playing around with OMP_NUM_THREADS
3 participants