mv * files from SCRATCH_DIR to RESULTS_DIR instead of cp -r, and make SCRATCH_DIR optional
#1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-S-Rosen
changed the title
mv * files from SCRATCH_DIR to RESULTS_DIR instead of cp -r, and make SCRATCH_DIR optional
|
@tomdemeyere: As described in the above summary, I modified the behavior of the I/O to address a few of your concerns. Please don't hesitate to let me know if you recommend any modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required Checklist
main.If you are an external contributor, you will see a comment from @buildbot-princeton. You can ignore this, as it is solely for admin purposes.
Summary of Changes
The default
SCRATCH_DIRwas changed toNone, such that everything is done in the same directory asRESULTS_DIRunless otherwise specified. This should make the "first calculation" easier on the new user, as everything will happen "before their eyes."Additionally, an
mv *style of operation is done instead ofcp -rwhen transferring files fromSCRATCH_DIRtoRESULTS_DIR, assuming the former is specified. This should speed up the process substantially.