Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address all issues raised by ruff #783

Closed
Andrew-S-Rosen opened this issue Aug 26, 2023 · 3 comments
Closed

Address all issues raised by ruff #783

Andrew-S-Rosen opened this issue Aug 26, 2023 · 3 comments
Labels
good-first-issue housekeeping Things to tidy up that are otherwise kind of boring

Comments

@Andrew-S-Rosen
Copy link
Member

No description provided.

@Andrew-S-Rosen Andrew-S-Rosen added good-first-issue housekeeping Things to tidy up that are otherwise kind of boring labels Aug 26, 2023
@Andrew-S-Rosen Andrew-S-Rosen mentioned this issue Aug 28, 2023
Closed
@OmAximani0
Copy link
Contributor

OmAximani0 commented Aug 31, 2023 •
edited
Loading

Hey, is this being worked on or can I work on this ? If I can please assign this to me.

@Andrew-S-Rosen
Copy link
Member Author

It's not being worked on right now! Feel free to take a stab at it.

Since this is a relatively small project at the moment, I don't usually bother with assigning issues as there's a low probability someone else is going to work on it.

@OmAximani0 OmAximani0 mentioned this issue Aug 31, 2023
Merged
2 tasks
Andrew-S-Rosen pushed a commit that referenced this issue Aug 31, 2023
@OmAximani0
Updated os.path.abspath() to Path.resolve() (#836)
46633ce 
- According to `ruff` updated the code
- #783 
- [x] I have read the [Developer
Guide](https://quantum-accelerators.github.io/quacc/dev/contributing.html).
Don't lie! 😉
- [x] My PR is on a custom branch and is _not_ named `main`.
@OmAximani0 OmAximani0 mentioned this issue Sep 1, 2023
Merged
Andrew-S-Rosen pushed a commit that referenced this issue Sep 1, 2023
@OmAximani0
Replaced os.getcwd() (#848)
148ad5c 
- Replaced the `os.getcwd()` with `Path.cwd()`
- Changes done only scoped to `ruff` errors
- Refs: #783

---------

Signed-off-by: OmAxiani0 <[email protected]>
@OmAximani0 OmAximani0 mentioned this issue Sep 2, 2023
Merged
Andrew-S-Rosen added a commit that referenced this issue Sep 4, 2023
@OmAximani0 @Andrew-S-Rosen
Replaced os.path.exists() and os.path.join() (#858)
96e9757 
- Also made some tweaks according to changes
- #783

---------

Signed-off-by: OmAxiani0 <[email protected]>
Co-authored-by: Andrew S. Rosen <[email protected]>
@Andrew-S-Rosen
Copy link
Member Author

Andrew-S-Rosen commented Sep 5, 2023 •
edited
Loading

@OmAximani0: I'm going to close this since all the important ones are taken care of now! The remaining few will probably just need to be ignored in the pyproject.toml. Thank you very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue housekeeping Things to tidy up that are otherwise kind of boring
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Andrew-S-Rosen @OmAximani0