Address mypy type hinting issues
#782
Labels
Comments
Andrew-S-Rosen
added
good-first-issue
housekeeping
Andrew-S-Rosen
added a commit
that referenced
this issue
Sep 2, 2023
Andrew-S-Rosen
changed the title
mypy type hinting issuesmypy type hinting issues
Merged
|
@Andrew-S-Rosen can you please assign me on this issue? |
|
@Andrew-S-Rosen I need to contribute to Open Source as part of my Course work. |
|
@abastola0, @jayanthkoduri: Feel free to work on a PR. I don't assign issues. This issue is large enough where it won't be possible to solve it completely with one PR. If you both plan to work on this, I recommend commenting here about which modules you plan to work on so you don't overlap. Like I mentioned, don't try to do them all. |
3 tasks
Andrew-S-Rosen
pushed a commit
that referenced
this issue
Jun 30, 2024
## Summary of Changes This merge request addresses some of the type hinting issues identified by MyPy. Ref: #782. ### Requirements - [X] My PR is focused on a [single feature addition or bugfix](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started/best-practices-for-pull-requests#write-small-prs). - [ ] My PR has relevant, comprehensive [unit tests](https://quantum-accelerators.github.io/quacc/dev/contributing.html#unit-tests). - [X] My PR is on a [custom branch](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-and-deleting-branches-within-your-repository) (i.e. is _not_ named `main`). ### Notes - Before contributing for the first time, read the ["Guidelines" section](https://quantum-accelerators.github.io/quacc/dev/contributing.html#guidelines). - If you are an external contributor, you will see a comment from [@buildbot-princeton](https://github.com/buildbot-princeton). This is solely for the maintainers. - When your code is ready for review, ping one of the [active maintainers](https://quantum-accelerators.github.io/quacc/about/contributors.html#active-maintainers).
3 tasks
Andrew-S-Rosen
pushed a commit
that referenced
this issue
Jul 1, 2024
## Summary of Changes Address MyPy type-checking errors in the espresso recipes module. Ref: #782. ### Requirements - [X] My PR is focused on a [single feature addition or bugfix](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started/best-practices-for-pull-requests#write-small-prs). - [ ] My PR has relevant, comprehensive [unit tests](https://quantum-accelerators.github.io/quacc/dev/contributing.html#unit-tests). - [X] My PR is on a [custom branch](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-and-deleting-branches-within-your-repository) (i.e. is _not_ named `main`). ### Notes - Before contributing for the first time, read the ["Guidelines" section](https://quantum-accelerators.github.io/quacc/dev/contributing.html#guidelines). - If you are an external contributor, you will see a comment from [@buildbot-princeton](https://github.com/buildbot-princeton). This is solely for the maintainers. - When your code is ready for review, ping one of the [active maintainers](https://quantum-accelerators.github.io/quacc/about/contributors.html#active-maintainers).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We won't be able to address them all in one PR, but steadily we should try resolving them by running
mypyon the codebase and addressing errors as they arise.The text was updated successfully, but these errors were encountered: