Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nova] API changes #20

Merged
merged 5 commits into from
May 13, 2024
Merged

[Nova] API changes #20

merged 5 commits into from
May 13, 2024

Conversation

VaibhavArora19
Copy link
Contributor

Closes #18

Yash-Garg
Yash-Garg reviewed May 13, 2024
View reviewed changes
Copy link
Member

@Yash-Garg Yash-Garg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add these default values also to the above fields.

Also need a totalBalance field for /user/balance API.

@Yash-Garg Yash-Garg merged commit 63841c6 into main May 13, 2024
@Yash-Garg Yash-Garg deleted the 18-nova-update branch May 13, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yash-Garg Yash-Garg Yash-Garg approved these changes

@sanchaymittal sanchaymittal Awaiting requested review from sanchaymittal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API changes required for mobile
2 participants
@VaibhavArora19 @Yash-Garg