-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Adding logo image for dark mode #231
Conversation
thanks @AakashGfude it looks like this will need some config updates. When you're ready if you could add instructions to the top level description block (and add that the future release notes) that would be amazing. Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
- Coverage 73.18% 73.07% -0.11%
==========================================
Files 2 2
Lines 261 260 -1
==========================================
- Hits 191 190 -1
Misses 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@AakashGfude is there any way to adjust the background in the image specified to match the website colour? maybe the answer is to make a transparent background (cc: @DrDrij) |
@mmcky You are right; a transparent background would be good. I can do it with photoshop tomorrow? |
@AakashGfude Good idea. I've cut out the dark background for transparency. If you send through feedback I'm happy to make another version. |
This is great - thanks @AakashGfude and @DrDrij |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @AakashGfude when you're ready please merge and release.
This PR adds the ability to specify a dark-mode version of your logo.
To use a separate logo image for dark mode, simply set it in configuration using the following setting:
The image is expected to be in the
_static
folder of your source repository