Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adding logo image for dark mode #231

Merged
merged 4 commits into from
Nov 1, 2023
Merged

ENH: Adding logo image for dark mode #231

merged 4 commits into from
Nov 1, 2023

Conversation

AakashGfude
Copy link
Member

@AakashGfude AakashGfude commented Oct 26, 2023

This PR adds the ability to specify a dark-mode version of your logo.
To use a separate logo image for dark mode, simply set it in configuration using the following setting:

html_theme_options:
    dark_logo: logo-image-dark-mode

The image is expected to be in the _static folder of your source repository

@github-actions github-actions bot temporarily deployed to commit October 26, 2023 14:45 Inactive
@mmcky
Copy link
Contributor

mmcky commented Oct 26, 2023

thanks @AakashGfude it looks like this will need some config updates. When you're ready if you could add instructions to the top level description block (and add that the future release notes) that would be amazing. Thanks.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #231 (812eec1) into master (e65778b) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   73.18%   73.07%   -0.11%     
==========================================
  Files           2        2              
  Lines         261      260       -1     
==========================================
- Hits          191      190       -1     
  Misses         70       70              
Flag Coverage Δ
pytests 73.07% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to commit October 30, 2023 01:24 Inactive
@github-actions github-actions bot temporarily deployed to commit October 30, 2023 01:47 Inactive
@github-actions github-actions bot temporarily deployed to commit October 30, 2023 02:18 Inactive
@github-actions github-actions bot temporarily deployed to commit October 30, 2023 02:48 Inactive
@github-actions github-actions bot temporarily deployed to commit October 30, 2023 03:28 Inactive
@mmcky
Copy link
Contributor

mmcky commented Oct 30, 2023

@AakashGfude is there any way to adjust the background in the image specified to match the website colour?

Screenshot 2023-10-30 at 2 29 00 pm

maybe the answer is to make a transparent background (cc: @DrDrij)

@AakashGfude
Copy link
Member Author

AakashGfude commented Oct 30, 2023

@mmcky You are right; a transparent background would be good. I can do it with photoshop tomorrow?

@DrDrij
Copy link
Member

DrDrij commented Oct 30, 2023

@AakashGfude Good idea. I've cut out the dark background for transparency. If you send through feedback I'm happy to make another version.

qe-logo-dark-transparent

@github-actions github-actions bot temporarily deployed to commit October 31, 2023 04:36 Inactive
@AakashGfude
Copy link
Member Author

Thanks @DrDrij , the image is working wonderfully now. @mmcky the netlify preview in this PR should have the updated image.

Screen Shot 2023-10-31 at 4 28 35 pm

@mmcky
Copy link
Contributor

mmcky commented Nov 1, 2023

This is great - thanks @AakashGfude and @DrDrij

@mmcky mmcky self-requested a review November 1, 2023 00:19
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @AakashGfude when you're ready please merge and release.

@AakashGfude AakashGfude merged commit 74b5bb9 into master Nov 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants